Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar event colors should accept color keywords #5743

Closed
lbursey-infor opened this issue Oct 14, 2021 · 6 comments · Fixed by #5981 or #6107
Closed

Calendar event colors should accept color keywords #5743

lbursey-infor opened this issue Oct 14, 2021 · 6 comments · Fixed by #5981 or #6107
Assignees
Labels
team: WFM For WFM Issues type: enhancement ✨ [3] Velocity rating (Fibonacci)

Comments

@lbursey-infor
Copy link

Is your feature request related to a problem? Please describe.
Calendar events currently only accept a hex value color (eg "#00FF00") when overriding the color of an event. Currently we get custom colors for calendar events both by hex and by keyword (eg "papayawhip").

Describe the solution you'd like
Calendar event should accept color keywords as well, instead of just accepting hex values.

Describe alternatives you've considered
WFM is having to maintain an array of color keywords and convert them to hexes, but this is not ideal.

@tmcconechy tmcconechy transferred this issue from infor-design/enterprise-ng Oct 14, 2021
@tmcconechy
Copy link
Member

Whats the array situation look like i.e. what do you have to do thats not ideal?
Did you notice this feature/example https://main-enterprise.demo.design.infor.com/components/calendar/test-event-color-override.html we did add a way to override colors.

But we are assuming you use on color pallette colors in the customization to stick to the "brand" https://github.com/infor-design/enterprise/blob/main/app/views/components/calndar/test-event-color-override.html#L55-L56

@tmcconechy tmcconechy added the [3] Velocity rating (Fibonacci) label Oct 14, 2021
@lbursey-infor
Copy link
Author

Hi Tim,

Current workaround is to maintain a map of all color keywords and their hex values (ie this list https://www.w3.org/wiki/CSS/Properties/color/keywords).

Regarding the color palette, our customers have custom colors already set up for certain events (eg vacation/PTO/sick day) and they need to be consistent across the app. That might mean some inconsistency in branding but it's required for some use cases.

@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Nov 3, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@tjamesallen15 tjamesallen15 moved this from To do to In progress in Enterprise 4.59.x (Dec 2021) Sprint Dec 20, 2021
@tjamesallen15 tjamesallen15 moved this from In progress to To do in Enterprise 4.59.x (Dec 2021) Sprint Dec 22, 2021
@tjamesallen15 tjamesallen15 moved this from To do to In progress in Enterprise 4.59.x (Dec 2021) Sprint Dec 27, 2021
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Jan 3, 2022
@tmcconechy tmcconechy removed this from Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Jan 4, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.60.x (Jan 2022) Sprint via automation Jan 4, 2022
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.60.x (Jan 2022) Sprint Jan 4, 2022
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Jan 6, 2022
@ericangeles ericangeles moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Jan 21, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Jan 24, 2022

The colors on the event types displayed in the calendar is also reflected in the legend. However, if you create a new event it will not match the legend color of event.
v4.60.0-dev
Steps

  1. Go to https://main-enterprise.demo.design.infor.com/components/calendar/test-event-custom-colors.html
  2. Create a new event (Add event Modal)
  3. See error.
  4. Try all event types
  5. Noticet that the color is always background-color: powderblue; border-left-color: royalblue;

@jbrcna jbrcna moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Jan 24, 2022
@CindyMercadoReyes
Copy link
Collaborator

BDD attached
BDDStory_github5743.docx
.

@ericangeles
Copy link
Contributor

@tjamesallen15 where are we on this?

@ericangeles ericangeles moved this from Failed QA (beta) to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Feb 9, 2022
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Feb 9, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Feb 10, 2022

this is now working as expected. v4.60.0-beta1 . thank you
https://4600-beta1-enterprise.demo.design.infor.com/components/calendar/test-event-custom-colors.html
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.60.x (Jan 2022) Sprint Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: WFM For WFM Issues type: enhancement ✨ [3] Velocity rating (Fibonacci)
Projects
No open projects
6 participants