Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker: Red diagonal line goes beyond its border when field-short class is used #5744

Closed
marclouisgenedeguzman opened this issue Oct 15, 2021 · 3 comments · Fixed by #5918
Closed

ColorPicker: Red diagonal line goes beyond its border when field-short class is used #5744

marclouisgenedeguzman opened this issue Oct 15, 2021 · 3 comments · Fixed by #5918
Assignees
@ericangeles
Labels
team: m3 Issues for m3 and sub teams type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
Enterprise 4.59.x (Dec 2021) Sprint

Comments

@marclouisgenedeguzman
Copy link

Describe the bug
When the color picker have field-short class, the red diagonal line goes beyond its border:

image

To Reproduce
Sample code reproduced here: https://stackblitz.com/edit/ids-quick-start-940-pg8ssj

Steps to reproduce the behavior:

  1. Go to https://stackblitz.com/edit/ids-quick-start-940-pg8ssj
  2. Select None color option
  3. Observe diagonal line

Expected behavior
Diagonal line should not go beyond the border

Version
ids-enterprise-ng 9.4.0 or higher
@tmcconechy
Copy link
Member

This can easily be seen on https://main-enterprise.demo.design.infor.com/components/form/example-compact-mode.html and is only happening in compact mode.

@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) team: m3 Issues for m3 and sub teams type: bug 🐛 labels Oct 15, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Oct 15, 2021
@tmcconechy tmcconechy changed the title None option for Color Picker: Red diagonal line goes beyond its border when field-short class is used Color Picker: Red diagonal line goes beyond its border when field-short class is used Oct 15, 2021
@tmcconechy tmcconechy changed the title Color Picker: Red diagonal line goes beyond its border when field-short class is used ColorPicker: Red diagonal line goes beyond its border when field-short class is used Oct 15, 2021
@EdwardCoyle
Copy link
Contributor

Need to adjust this for use inside .form-field-compact: https://github.com/infor-design/enterprise/blob/main/src/components/colorpicker/_colorpicker.scss#L193

@EdwardCoyle EdwardCoyle added this to To do in Enterprise 4.58.x (Nov 2021) Sprint via automation Oct 27, 2021
@ericangeles ericangeles self-assigned this Nov 5, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.59.x (Dec 2021) Sprint Dec 3, 2021
@ericangeles ericangeles mentioned this issue Dec 3, 2021
Merged
1 task
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Dec 3, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 7, 2021
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.59.x (Dec 2021) Sprint Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
team: m3 Issues for m3 and sub teams type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.59.x (Dec 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5733 - Fix colorpicker red diagonal line in form compact mode infor-design/enterprise
5 participants
@tmcconechy @EdwardCoyle @ericangeles @CindyMercadoReyes @marclouisgenedeguzman