Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Dialog does not always close with escape key #5796

Closed
claudenbach opened this issue Oct 27, 2021 · 2 comments · Fixed by #5939
Closed

Modal: Dialog does not always close with escape key #5796

claudenbach opened this issue Oct 27, 2021 · 2 comments · Fixed by #5939
Assignees
@yohannahbautista
Labels
team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.59.x (Dec 2021) Sprint

Comments

@claudenbach
Copy link
Contributor

Describe the bug
A modal dialog that contains a datagrid, when focus is on a filter row input element, the escape key is not closing the dialog.

Steps to reproduce the behavior:

  1. Using the attached 'test-modal-datagrid-escape-closing.html'
  2. Click on 'Open Modal'
  3. Using the shift+tab key or using mouse set focus on a filter row input element
  4. Hit the escape key

Expected behavior
Escape key will close the modal regardless of which element has the focus.

Version

  • ids-enterprise: v4.57.0-dev

Additional context
Many Landmark clients are keyboard users, so they expect consistent behavior for hotkeys.
@claudenbach
Copy link
Contributor Author

Git-5796.zip

@tmcconechy tmcconechy added the [2] Velocity rating (Fibonacci) label Nov 1, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Nov 1, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@yohannahbautista yohannahbautista mentioned this issue Dec 13, 2021
Merged
2 tasks
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Dec 14, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 17, 2021
@nganotice
Copy link

This has been QA tested and passed on v4.59.0-dev.

https://main-enterprise.demo.design.infor.com/components/modal/test-modal-datagrid-escape-closing.html

Moving this ticket to Done.

Thanks!

@nganotice nganotice moved this from Ready for QA (beta) to Done in Enterprise 4.59.x (Dec 2021) Sprint Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yohannahbautista yohannahbautista

Labels
team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.59.x (Dec 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5796 - Close modal if Escape key is pressed in datagrid infor-design/enterprise
4 participants
@tmcconechy @claudenbach @nganotice @yohannahbautista