Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listview: alert icon is missing in RTL #5827

Closed
jonathanamiran opened this issue Nov 9, 2021 · 6 comments · Fixed by #5925 or #5938
Closed

Listview: alert icon is missing in RTL #5827

jonathanamiran opened this issue Nov 9, 2021 · 6 comments · Fixed by #5925 or #5938
Assignees
@ericangeles
Labels
focus: good first issue Good for for one of the first few issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.59.x (Dec 2021) Sprint

Comments

@jonathanamiran
Copy link

Describe the bug
When using class="alert-text" in Listview in RTL mode the red icon disappears

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://design.infor.com/code/ids-enterprise/latest/demo/components/listview/example-status.html?locale=he-IL
  2. See that the icon is missing
  3. Compare with https://design.infor.com/code/ids-enterprise/latest/demo/components/listview/example-status.html
  4. it was OK in previous version https://design.infor.com/code/ids-enterprise/4.34.3/demo/components/listview/example-status.html?locale=he-IL

Expected behavior
Icons should be visible in

Version

  • ids-enterprise: v4.56.0
  • it was OK in previous versions for example in v4.34

Screenshots
LTR:
image
RTL:
image

Platform

  • OS Version: Windows 10
  • Browser Name: Chrome
  • Browser Version: 95

Additional context
Thanks
@tmcconechy tmcconechy added focus: good first issue Good for for one of the first few issues type: bug 🐛 [2] Velocity rating (Fibonacci) labels Nov 9, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Nov 9, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@ericangeles ericangeles self-assigned this Dec 2, 2021
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.59.x (Dec 2021) Sprint Dec 6, 2021
@ericangeles ericangeles mentioned this issue Dec 6, 2021
Merged
1 task
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Dec 6, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 7, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Dec 9, 2021

v4.59.0-dev
this is now working as expected. However, I noticed that in Safari the parenthesis is different. see image below.
verified in https://main-enterprise.demo.design.infor.com/components/listview/example-status.html?locale=he-IL
image

Classic
image

Browserstack: Mac OS Monterey Safari 15
image

@jonathanamiran
Copy link
Author

Thanks.
I confirm that also in Chrome Mobile and Android WebView it works as expected.
image

In Firefox (Windows) there's still an issue. However, we use Chrome Windows and Android WebView so Firefox is quite irrelevant for us.

image

@tmcconechy
Copy link
Member

@jonathanamiran I think this is just a byproduct of it being english text and being RTL and how the browser treats it. So i dont think we can fix that but it should be ok with native text.

I do see the ff issue on https://main-enterprise.demo.design.infor.com/components/listview/example-status.html?locale=he-IL still so we should fix that. Reopening for @ericangeles to take a second look

@tmcconechy tmcconechy reopened this Dec 9, 2021
Enterprise 4.59.x (Dec 2021) Sprint automation moved this from Ready for QA (beta) to To do Dec 9, 2021
@tmcconechy tmcconechy moved this from To do to Failed QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 9, 2021
@jonathanamiran
Copy link
Author

Just to make sure, with Hebrew characters in Chrome it looks great:
image

But in FF there's still a problem:
image

@tmcconechy
Copy link
Member

Yeah clearly we need to fix the icon in FF. Will take another pass

@ericangeles ericangeles moved this from Failed QA (beta) to In progress in Enterprise 4.59.x (Dec 2021) Sprint Dec 10, 2021
@ericangeles ericangeles mentioned this issue Dec 13, 2021
Merged
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Dec 13, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 17, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Dec 20, 2021

QA Passed
v4.59.0-dev
verified in https://main-enterprise.demo.design.infor.com/components/listview/example-status.html?locale=he-IL
Safari
image

Chrome
image

Firefox
image

Edge
image

Mobile
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.59.x (Dec 2021) Sprint Dec 20, 2021
@jbrcna jbrcna mentioned this issue Dec 28, 2021
Closed
@jonathanamiran jonathanamiran mentioned this issue May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
focus: good first issue Good for for one of the first few issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.59.x (Dec 2021) Sprint
  
Done
Milestone
No milestone
4 participants
@tmcconechy @ericangeles @jonathanamiran @jbrcna