Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale: Filipino Translations Issues #5864

Closed
nganotice opened this issue Nov 15, 2021 · 11 comments
Closed

Locale: Filipino Translations Issues #5864

nganotice opened this issue Nov 15, 2021 · 11 comments
Assignees
Labels
focus: dark mode dark mode focus: translation For translation issues type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@nganotice
Copy link

nganotice commented Nov 15, 2021

Describe the bug
Filipino Translations issues

To Reproduce
Steps to reproduce the behavior:
1st issue

  1. Go to https://main-enterprise.demo.design.infor.com/components/locale/test-translations.html?locale=tl-PH
  2. Click on "higit pa/more"
  3. Click on "mga mode"
  4. See error that "Dark" isn't translated

2nd issue

  1. Go to https://main-enterprise.demo.design.infor.com/components/locale/test-translations.html?locale=tl-PH
  2. Click on Datagrid tab
  3. See error that some of the Headers aren't translated (Percent, Date, Record)

3rd issue

  1. Go to https://main-enterprise.demo.design.infor.com/components/locale/test-translations.html?locale=tl-PH
  2. Click on Kalendaryo tab
  3. Make the browser smaller
  4. See error that Legend isn't translated

4th issue

  1. Go to https://main-enterprise.demo.design.infor.com/components/locale/test-translations.html?locale=tl-PH
  2. Click on Mga Form tab
  3. See error that some of the Labels aren't translated (Character, View Source)

Expected behavior
All issues should be translated to Filipino/Tagalog

Version
v4.58.0-dev

Screenshots
1st issue Dark = Madilim
1st

2nd issue Percent = Porsyento, Date = Petsa, Record = Rekord
Screen Shot 2021-10-28 at 10 18 32 AM

3rd issue
Screen Shot 2021-10-28 at 11 52 00 AM

4th issue Character = Karakter, View Source = Tingnan ang Pinagmulan
Screen Shot 2021-10-28 at 10 23 06 AM

Platform
All browsers/mobile devices

Additional context
N/A

@nganotice
Copy link
Author

CC @tmcconechy @ericangeles

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 focus: translation For translation issues labels Nov 15, 2021
@tmcconechy
Copy link
Member

cc @hwondergem

@jehanismael
Copy link

jehanismael commented Nov 19, 2021

Feedback summary:

1st issue:
Use the Dark > Madilim translation in the menu, but retain the English names for these dark mode themes:

  • ClassicDarkTheme
  • Dark
  • NewDarkTheme
  • SohoDarkTheme
  • UpliftDarkTheme

2nd issue
Translators missed this one. Please use suggested translations for Percent = Porsyento and Date = Petsa

3rd issue
Translators agreed to use Record > Rekord and Record (list type, as shown in screenshot) > Talaan

4th issue Character = Karakter, View Source = Tingnan ang Pinagmulan
Translators missed this one as well. Please use suggested translations

Let me know if there are any other issues. Thanks!

@tmcconechy
Copy link
Member

@jehanismael i checked through the latest new translation files i got but not all of these points appear in the translation file (a few do)

Can you check again... cc @hwondergem

@HVD617
Copy link

HVD617 commented Dec 27, 2021

Hi @tmcconechy,

Suzzette Cristobal and I will review the missing translations and make the appropriate changes. Thanks!

@tmcconechy tmcconechy added this to To do in Enterprise 4.61.x (Feb 2022) Sprint via automation Feb 10, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.61.x (Feb 2022) Sprint Feb 10, 2022
@tmcconechy
Copy link
Member

Got the new strings. Not everything may be exactly how you asked @nganotice but the translators translated some of these things.

@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.61.x (Feb 2022) Sprint Feb 18, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Feb 21, 2022

This has been QA tested and passed on https://main-enterprise.demo.design.infor.com/components/locale/test-translations.html?locale=tl-PH

1st issue
image

2nd issue
percent and date is still not translated.
image
but Record is now Talaan
image

3rd issue
legends in smaller view port is still not translated
image

4th issue
image

i also noticed a few things that could also be translated but I'm not sure if this makes sense.

  • number could be translated to numero

image

  • view visual could be translated to tingnan ang visual ; assumption: since view source had been translated

image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.61.x (Feb 2022) Sprint Feb 21, 2022
@HVD617
Copy link

HVD617 commented Feb 22, 2022

Hi @jbrcna,

Updates made on the raised translation issues. Let me know if everything is now in order or if additional changes are warranted.

Thanks!

@hwondergem
Copy link

@tmcconechy, delivery updated,
\nlbavwmemoq2\cc\ToDev\SohoUX\tl-PH-messages.js 55,645 02/22/2022 09:13

@tmcconechy tmcconechy moved this from Done to Pending Review in Enterprise 4.61.x (Feb 2022) Sprint Feb 22, 2022
@tmcconechy tmcconechy self-assigned this Feb 22, 2022
@tmcconechy
Copy link
Member

@jbrcna i added the new strings should fix some things - im sure we cant fix all of this. In particular the VISUAL button is an icon so it cant be translated right now. So i would ignore this point (or we can make a new issue)

@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.61.x (Feb 2022) Sprint Feb 22, 2022
@CindyMercadoReyes
Copy link
Collaborator

Thanks at @tmcconechy for getting back to @jbrcna. I will move this ticket to the Done folder.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.61.x (Feb 2022) Sprint Feb 22, 2022
@inforandy inforandy added the focus: dark mode dark mode label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: dark mode dark mode focus: translation For translation issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

No branches or pull requests

8 participants