Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon: Wrong color on #icon-translate #5870

Closed
guoliang opened this issue Nov 16, 2021 · 3 comments · Fixed by #6053
Closed

Icon: Wrong color on #icon-translate #5870

guoliang opened this issue Nov 16, 2021 · 3 comments · Fixed by #6053
Assignees
@tmcconechy
Labels
design Needs input from IDS Design Team type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.60.x (Jan 2022) Sprint

Comments

@guoliang
Copy link
Contributor

Describe the bug

Look in the following image
image

I have set inline style to the icons and even added !important to make it explicit
image

Even so the #icon-translate doesn't get the color I want. This is an issue since without the above styling the default color should be white, but it isn't for the translate icon now.

This issue happens in version 10.10.0 of enterprise-ng, and was not an issue 10.9.0

Ref
https://main-enterprise.demo.design.infor.com/components/icons/example-index.html

Version

  • ids-enterprise-ng: 10.10.0

Additional context
Add any other context about the problem here.
@tmcconechy tmcconechy transferred this issue from infor-design/enterprise-ng Nov 16, 2021
@tmcconechy tmcconechy changed the title Wrong color on #icon-translate Icon: Wrong color on #icon-translate Nov 16, 2021
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) design Needs input from IDS Design Team type: bug 🐛 labels Nov 16, 2021
@tmcconechy
Copy link
Member

cc @kevinwhitedesign can you check this new icon. It seems to have a hard coded fill/stroke unlike the others so it can not be colorized.

We can fix it with the next round of icons?

@tmcconechy
Copy link
Member

tmcconechy commented Jan 3, 2022 •
edited

@kevinwhitedesign any chance of getting this fixed? Its been reported now multiple times. Would suggest fixing this with any other icon changes at once as it takes a while to retest

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) and removed [1] Velocity rating (Fibonacci) labels Jan 3, 2022
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Jan 3, 2022
@tmcconechy tmcconechy mentioned this issue Jan 3, 2022
Closed
@davidcarlsonberg davidcarlsonberg self-assigned this Jan 6, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.60.x (Jan 2022) Sprint via automation Jan 6, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Jan 21, 2022
@tmcconechy tmcconechy mentioned this issue Jan 21, 2022
Merged
1 task
@CindyMercadoReyes CindyMercadoReyes moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Jan 25, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Jan 26, 2022

QA Passed
v4.60.0-dev
https://main-enterprise.demo.design.infor.com/components/icons/example-index.html
image

image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.60.x (Jan 2022) Sprint Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcconechy tmcconechy

Labels
design Needs input from IDS Design Team type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.60.x (Jan 2022) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5870- Bump ids for new icons infor-design/enterprise
4 participants
@guoliang @tmcconechy @davidcarlsonberg @jbrcna