Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker: Add option to limit hours #5880

Closed
4 tasks
tmcconechy opened this issue Nov 19, 2021 · 5 comments · Fixed by #5952
Closed
4 tasks

TimePicker: Add option to limit hours #5880

tmcconechy opened this issue Nov 19, 2021 · 5 comments · Fixed by #5952
Assignees
Labels
focus: web-components For work in the wc project team: WFM For WFM Issues type: enhancement ✨ [2] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Nov 19, 2021

Describe the Feature
There are use cases where we need the user to pick within a defined range:
ex. Pick a time during your scheduled work hour (8am-4pm). This just puts less hours in the list..

Design: https://www.figma.com/file/b4FR4NZg5yUHoEj2scWjPM/Timepicker?node-id=4%3A2

Tasks

  • Add a setting hourRange: [0, 24]
  • Add an example
  • Add a test
  • Add a test and the same setting to the web component version

Expected behavior
A clear and concise description of what you expected to happen.

Version

  • ids-enterprise: [e.g. v4.9.0 or v4.10.0]

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • Infor Application/Team Name: [e.g. Infor XYZ, Infor ABC]
  • Device: (if applicable) [e.g. iPhone 6 or Samsung Galaxy S6]
  • OS Version: [e.g. Windows 10 or iOS 8]
  • Browser Name: [e.g. chrome, safari, stock browser]
  • Browser Version: [e.g. 22, 66.0.3359.181 (Official Build) (64-bit)]

Additional context
Add any other context about the problem here.

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: enhancement ✨ focus: web-components For work in the wc project team: WFM For WFM Issues labels Nov 19, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Nov 19, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@tjamesallen15
Copy link
Contributor

Hello @tmcconechy, when I clicked the design link it says file not found.
image

@tmcconechy
Copy link
Member Author

I asked @kevinwhitedesign should be good now 👍🏻

@tjamesallen15
Copy link
Contributor

I asked @kevinwhitedesign should be good now 👍🏻

Just checked the link. Still the same issue.

@tjamesallen15 tjamesallen15 moved this from To do to In progress in Enterprise 4.59.x (Dec 2021) Sprint Dec 14, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Dec 15, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 17, 2021
@CindyMercadoReyes
Copy link
Collaborator

BDD attached.
BDDStory_github5880.docx

@jbrcna
Copy link
Contributor

jbrcna commented Dec 20, 2021

This has been QA tested and passed on v4.59.0-dev.
verified in https://main-enterprise.demo.design.infor.com/components/timepicker/example-hour-range.html
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: web-components For work in the wc project team: WFM For WFM Issues type: enhancement ✨ [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants