Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model: Dialog containing a rich text editor has a row height issue #5937

Closed
claudenbach opened this issue Dec 10, 2021 · 7 comments · Fixed by #6050
Closed

Model: Dialog containing a rich text editor has a row height issue #5937

claudenbach opened this issue Dec 10, 2021 · 7 comments · Fixed by #6050
Assignees
Labels
team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@claudenbach
Copy link
Contributor

Describe the bug:
When rapidly typing into the rich text editor that is in a modal dialog, the line height of the rows is being changed when the user pauses from typing.

Steps to reproduce the behavior:

  1. Using https://main-enterprise.demo.design.infor.com/components/editor/test-modal.html
  2. Click on Show Modal
  3. Clear the existing content with the rich text component
  4. Rapidly type into the text editor several characters then the enter key (repeat for a couple of lines) then stop

Notice that the height of the rows within the editor are changed when the user pauses from typing.

I've only noticed this behavior happening when the editor is contained in a modal dialog.

Version
ids 4.59.0-dev

Additional Context:
Have a customer reporting this issue. The user is doing heads-down data entry, rapidly typing into the editor.

@claudenbach
Copy link
Contributor Author

Example from components/editor/test-modal.html:

RichTextIssue

@claudenbach
Copy link
Contributor Author

Landmark example:
LMCLIENT-38399

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) [3] Velocity rating (Fibonacci) and removed [5] Velocity rating (Fibonacci) labels Dec 10, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Dec 10, 2021
@tmcconechy
Copy link
Member

Tips to someone that picks this up:

To clarify we added a setting so it will always wrap in P tags so each time you hit enter it makes a new

tag which has space between each one. If you dont want a P tag you can do shift+enter.

But it seems in this one case the container isnt yet wrapped possibly the modal is prevent this from happening https://github.com/infor-design/enterprise/blob/main/src/components/editor/editor.js#L650

@tjamesallen15
Copy link
Contributor

@tmcconechy I tried this at http://localhost:4000/components/editor/example-index.html and it seems behaving exactly with the one inside the modal.

@tmcconechy
Copy link
Member

@tjamesallen15 i did see this issue - sounds like from our teams chat you were eventually able to reproduce?

@tjamesallen15
Copy link
Contributor

@tjamesallen15 i did see this issue - sounds like from our teams chat you were eventually able to reproduce?

yes. still looking at it.

@jbrcna
Copy link
Contributor

jbrcna commented Jan 26, 2022

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.60.x (Jan 2022) Sprint Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants