Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations from English to Swedish #5987

Closed
Annfo637 opened this issue Jan 4, 2022 · 18 comments · Fixed by #6079
Closed

Translations from English to Swedish #5987

Annfo637 opened this issue Jan 4, 2022 · 18 comments · Fixed by #6079
Assignees
Labels
focus: translation For translation issues type: bug 🐛 [1] Velocity rating (Fibonacci)

Comments

@Annfo637
Copy link

Annfo637 commented Jan 4, 2022

Describe the bug
One translation should be updated and one translation doesn't seem to work at all.

To Reproduce

Steps to reproduce the behavior:

  1. In Portal V2/Homepages, change language to Swedish and add the Notes (Anteckningar) widget.
  2. Click on the ellipse (...) and choose "Hyperlänk".
  3. The heading in the dialog should be "länk" instead of "fästpunktslänk". [New window] doesn't seem to be translated at all.

Expected behavior
As above, "fästpunktslänk" should be "länk", also "[New Window]" should be translated to "Nytt fönster".

Version

  • ids-enterprise: 4.56.0

Screenshots
image

Platform

  • Infor Application/Team Name: Portal V2
  • OS Version: Windows 10
  • Browser Name: Chrome
  • Browser Version: 95.0.4638.69 (Official Build) (64-bit)
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) focus: translation For translation issues type: bug 🐛 labels Jan 4, 2022
@tmcconechy
Copy link
Member

cc @hwondergem can you check this one as well? Thanks!

@tmcconechy
Copy link
Member

Also @hwondergem i sent an invite https://github.com/orgs/infor-design/people/pending_invitations just so i can assign issues to you. Let me know if you can see it or check your email attached?

@hwondergem
Copy link

@tmcconechy, @Annfo637 Feedback from the linguist:
The translation of “anchor” comes from MS Language Portal, our primary source for IT terminology. Changing the translation to “länk” creates a conflict with the translation of “Insert Link”. According to the comments, “Insert Anchor” means “Insert a hyperlink in an editor, so maybe “anchor” should be translated as “hyperlänk” instead? (In that case, why use “anchor” in the source?)

image

The string [New window] does not exist in IDS strings file, only New Window without the brackets and with an uppercase W.

@tmcconechy
Copy link
Member

Anchor (a) tag is synonymous with hyperlink in english. But we could easily change it to InsertHyperlink if that would help? I think for translation i guess you would call it whatever of the two makes the most sense? In case you want us to change it i added an additional string to nlbavwmemoq2/cc/FromDev/SohoUX/

The string is NewWindow the brackets indicate something wasnt found in the translations but i cannot see that here. So i assume something wrong on the Dev teams end @Annfo637

https://main-enterprise.demo.design.infor.com/components/editor/example-index.html?locale=sv-SE
Screen Shot 2022-01-05 at 9 21 57 AM

@hwondergem
Copy link

@tmcconechy, if the concepts of anchor and hyperlink are synonymous, maybe using one is less confusing.
However, according to Techopedia:

An anchor is an HTML tag that identifies a link to text or an image on the same page or to another specific location. An anchor can be used in two ways:

By using the “href” attribute to create a link to another page
By using the "name" attribute to create a bookmark within a page
The hyperlink text on which the user clicks is known as the anchor text. Anchor text is also known as link text or a link label.

@tmcconechy
Copy link
Member

@hwondergem yep thats also my understanding. So technically this string is used to insert an anchor tag in the editor https://main-enterprise.demo.design.infor.com/components/editor/example-index.html but refering to it as a link/hyperlink might be more "user friendly". So i guess whichever is the best for translators?

@hwondergem
Copy link

OK @tmcconechy, in case the following are synonymous, update to comment: 'Insert a hyperlink in an editor, synonymous to hyperlink' for the first and third so translators can decide how to translate?
InsertAnchor: { id: 'InsertAnchor', value: 'Insert Anchor', comment: 'Insert a hyperlink in an editor' },
InsertHyperlink: { id: 'InsertHyperlink', value: 'Insert Hyperlink', comment: 'Insert a hyperlink in an editor' },
(...)
InsertLink: { id: 'InsertLink', value: 'Insert Link', comment: 'Insert Link in an editor' },

@tmcconechy
Copy link
Member

The only thing is i have to pick one of those three to actually use. I cant use them all. So maybe it can be..

 InsertHyperlink: { id: 'InsertHyperlink', value: 'Insert Hyperlink', comment: 'Insert a hyperlink (synonymous with link or anchor tag) into an editor ' },

@hwondergem
Copy link

Yes, that's the best solution! Thanks.

@SofiK
Copy link
Contributor

SofiK commented Jan 10, 2022

Hi, "New window" should be "Nytt fönster" in Swedish. "Nästa" means "Next".

@asandberg2
Copy link

The incorrect translation of New Window was discovered previously and has been corrected in the current version of the translation files.

@tmcconechy
Copy link
Member

Seems to be incorrect here https://github.com/infor-design/enterprise/blob/main/src/components/locale/cultures/sv-SE.js#L346 - but if you fixed it in the next version i dont have yet then feel free to ignore.

@asandberg2
Copy link

Yes, it is fixed in the next version:

image

@tmcconechy tmcconechy self-assigned this Jan 31, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.60.x (Jan 2022) Sprint via automation Jan 31, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Jan 31, 2022
@ericangeles ericangeles moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Feb 3, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Feb 4, 2022

working as expected. moving this ticket to Done. thanks
v4.60.0-dev
https://main-enterprise.demo.design.infor.com/components/editor/example-index.html?locale=sv-SE
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.60.x (Jan 2022) Sprint Feb 4, 2022
@asandberg2
Copy link

Although this issue is closed, I would like to make sure that everything is clear regarding the translation of "Insert Anchor". In the latest translation update, a new string for "Insert Hyperlink" has been included, in addition to "Insert Anchor". Both have the same comment "Insert a hyperlink in an editor". Should both strings really be translated as "Insert Hyperlink"? Why have two different strings in English if the word for "anchor" should not be used in the localized version? Sorry, but this is confusing. I have currently translated "anchor" to "hyperlänk", but I don't think that it is a good solution.

@tmcconechy
Copy link
Member

I talked to the translators and they wanted to call it "Link" in English and that would be easiest to translate apparently.
So thats what it is now.

It may take some time for the translators to translate the new string (month usually) but should be solved when that is done. Also have to assume providing that they translate "link" to something you would agree with but thats their decision as i've seen "hyperlänk" and "länk".

For backwards compatibility i do still have the old strings for hyperlink and anchor but they aren't used after this anymore.

@asandberg2
Copy link

OK, if the old string "Insert Anchor" will not be used anymore, I will translate "anchor" as anchor (fästpunkt) in the Swedish translation and not as hyperlink, to avoid any confusion if "anchor" reappears somewhere else in future updates. Thank you!

@tmcconechy
Copy link
Member

Yeah makes sense - the string isnt presently used but you never know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: translation For translation issues type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants