Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Opening the add hyperlink modal via CTRL-H is bugged #6015

Closed
xqses opened this issue Jan 12, 2022 · 1 comment · Fixed by #6125
Closed

Editor: Opening the add hyperlink modal via CTRL-H is bugged #6015

xqses opened this issue Jan 12, 2022 · 1 comment · Fixed by #6125
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@xqses
Copy link

xqses commented Jan 12, 2022

Describe the bug
The Soho editor allows a user to enter the Add Hyperlink modal via pressing CTRL-H on the keyboard. If the add hyperlink option in the toolbar is not visible for some reason, this will cause an error in the modal close event.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://main-enterprise.demo.design.infor.com/components/editor/example-index.html'
  2. Resize the browser window such that the add hyperlink option is not visible
  3. Press ctrl-H to open the add hyperlink modal
  4. Attempt to add the hyperlink (press 'insert' button)
  5. The interface will break and the user has to refresh the page.

Expected behavior
The new hyperlink would be added to the textarea.

Version

  • ids-enterprise: v4.60.0

Screenshots
Console error: https://imgur.com/a/25t9gxJ
Line numbers in the editor.js file: https://imgur.com/a/K80ndjk

Platform

  • Infor Application/Team Name: Infor Homepages
  • OS Version: Windows 10
  • Browser Name: edge
  • Browser Version: Version 97.0.1072.55 (Official build) (64-bit)
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 team: homepages Issues for the homepages team labels Jan 12, 2022
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Jan 12, 2022
@tmcconechy tmcconechy removed the team: homepages Issues for the homepages team label Jan 12, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.61.x (Feb 2022) Sprint via automation Jan 26, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.61.x (Feb 2022) Sprint Feb 15, 2022
@CindyMercadoReyes CindyMercadoReyes moved this from Pending Review to Ready for QA (beta) in Enterprise 4.61.x (Feb 2022) Sprint Feb 22, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Feb 23, 2022

this issue is now resolved.
verified in https://main-enterprise.demo.design.infor.com/components/editor/example-index.html
Large GIF (482x620)

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.61.x (Feb 2022) Sprint Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants