Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Setting stretchColumn to "last" does not stretch the last column #6063

Closed
s-werking opened this issue Jan 26, 2022 · 8 comments · Fixed by #6070
Closed

Datagrid: Setting stretchColumn to "last" does not stretch the last column #6063

s-werking opened this issue Jan 26, 2022 · 8 comments · Fixed by #6070
Assignees
Labels
team: lawson For lawson issues type: regression bug ↩️ [3] Velocity rating (Fibonacci)

Comments

@s-werking
Copy link
Contributor

s-werking commented Jan 26, 2022

Describe the bug
The last column does not get stretched when the datagrid setting stretchColumn is set to "last".

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://localhost:4000/components/datagrid/test-stretch-last-column.html
  2. Note that the last column is not stretched
  3. Remove the stretchColumn setting in test-stretch-last-column.html
  4. Go to http://localhost:4000/components/datagrid/test-stretch-last-column.html
  5. Note that the table looks the same without the stretchColumn setting

Expected behavior
When the stretchColumn setting is set to "last", the columns should all be their set pixel widths and the last column should fill the rest of the table if there is any width left. If the total column widths are over the table width, then all of the columns including the last should be their set pixel width.

Version

  • ids-enterprise: v4.60.0-dev

Platform

  • Infor Application/Team Name: lawson
  • OS Version: Windows10
  • Browser Name: chrome
  • Browser Version: Version 97.0.4692.99 (Official Build) (64-bit)
    Related Lawson JIRA Ticket: LSF-50627
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 team: lawson For lawson issues labels Jan 26, 2022
@tmcconechy
Copy link
Member

As a workaround what seems to work is setting it to the name.

stretchColumn: 'orderDate', // or columns[columns.length -1].id

Maybe we phase last out for simplicity. Would suggest doing this...

@s-werking
Copy link
Contributor Author

The only issue with that solution is that when you resize the last column to be close to the end of the table and resize the next column over, the last column disappears. Gif for reference:
Disappearing last column

@tmcconechy
Copy link
Member

I think the stretch column should be used for readonly views (no resize). Its a bit limited. Would probably be better off without it.

This is probably fixable but i might have to rework how the columns are done. I will consider this for the v5

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) type: regression bug ↩️ and removed [2] Velocity rating (Fibonacci) type: bug 🐛 labels Jan 26, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.60.x (Jan 2022) Sprint via automation Jan 27, 2022
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) and removed [5] Velocity rating (Fibonacci) labels Jan 27, 2022
@tmcconechy
Copy link
Member

tmcconechy commented Jan 27, 2022

@ericangeles think we can look it this? i may need to pick it up tho.

  1. We the word last doesnt work anymore (...) more minor
  2. The resize removes the last column of the page...

@tmcconechy
Copy link
Member

@tmcconechy tmcconechy self-assigned this Jan 27, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Jan 27, 2022
@ericangeles ericangeles moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Jan 31, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Feb 2, 2022

this is now working in Chrome but Failed in Safari browser
v4.60.0-dev
Browserstack SAfari Browser
https://main-enterprise.demo.design.infor.com/components/datagrid/test-stretch-last-column.html
Large GIF (1206x632)

Also, try resizing the row height after you resize the column. it will look like this
Steps

  1. resize the last column to the right -> make sure you can still see it and scroll to it
  2. resize the next column to it to the left -> make sure you can still scroll right and see it
  3. Change row height to small or any
    image

@jbrcna jbrcna moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Feb 2, 2022
@tmcconechy
Copy link
Member

Lets make a new issue for that bit. Im not certain that we will be able to fix it and this feature is pretty much deprecated.

@tmcconechy tmcconechy moved this from Failed QA (beta) to Done in Enterprise 4.60.x (Jan 2022) Sprint Feb 2, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Feb 3, 2022

Thanks for clarification @tmcconechy , here's the ticket for the new issue. #6087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: lawson For lawson issues type: regression bug ↩️ [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants