Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAP: example markup issue #6065

Closed
jbrcna opened this issue Jan 27, 2022 · 10 comments · Fixed by #6172 or #6224
Closed

CAP: example markup issue #6065

jbrcna opened this issue Jan 27, 2022 · 10 comments · Fixed by #6172 or #6224
Assignees
Labels
priority: trival Least important issues type: demo-app bug 🪲 [2] Velocity rating (Fibonacci)

Comments

@jbrcna
Copy link
Contributor

jbrcna commented Jan 27, 2022

Describe the bug
there are some fields that are missing in this example page

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://main-enterprise.demo.design.infor.com/components/contextualactionpanel/example-markup.html
  2. Click the button
  3. See error

Expected behavior
image

Version

  • ids-enterprise:4.60.0-dev

Screenshots
image

Platform
all browsers

Additional context
Add any other context about the problem here.

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Jan 27, 2022
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Jan 27, 2022
@tmcconechy
Copy link
Member

Seems like just a bad example hasnt worked in a while https://4550-enterprise.demo.design.infor.com/components/contextualactionpanel/example-markup.html

So marking minor

@jbrcna
Copy link
Contributor Author

jbrcna commented Mar 14, 2022

this now looks as expected. However, the fields arent working.
v4.62.0-dev
https://main-enterprise.demo.design.infor.com/components/contextualactionpanel/example-markup.html
Large GIF (784x554)

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.62.x (Mar 2022) Sprint Mar 14, 2022
@jbrcna jbrcna moved this from Done to Failed QA (beta) in Enterprise 4.62.x (Mar 2022) Sprint Mar 14, 2022
@tmcconechy
Copy link
Member

this seems like they should work... @ericangeles any ideas?

@ericangeles
Copy link
Contributor

@tmcconechy hmm can't recall but we can take a look at this one.

@tmcconechy
Copy link
Member

Sure feels like it could be worth a look to make sure nothing is broken cc @davidcarlsonberg @ericangeles

@davidcarlsonberg
Copy link
Contributor

#6224 should fix the dropdown issue. They were not initialized.

@jbrcna jbrcna moved this from Failed QA (beta) to Ready for QA (beta) in Enterprise 4.62.x (Mar 2022) Sprint Mar 31, 2022
@jbrcna jbrcna moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.62.x (Mar 2022) Sprint Mar 31, 2022
@jbrcna
Copy link
Contributor Author

jbrcna commented Mar 31, 2022

this is now working in New Theme. However, when using classic theme it creates elements after clicking the#trigger-1button
https://main-enterprise.demo.design.infor.com/components/contextualactionpanel/example-markup.html?theme=classic&mode=light&colors=2578a9
image
image

@davidcarlsonberg
Copy link
Contributor

I'm not sure why that was even originally originally in the example. Could we just remove the insertAfter @tmcconechy or is this meant to demonstrate something?

@tmcconechy
Copy link
Member

Its basically trying to show you can have markup to construct the contextual action panel so as long as there is markup in the page and it works and shows that in the CAP, i think that should be fine

@tmcconechy tmcconechy moved this from Failed QA (beta) to Ready for QA (beta) in Enterprise 4.62.x (Mar 2022) Sprint Apr 4, 2022
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.62.x (Mar 2022) Sprint Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: trival Least important issues type: demo-app bug 🪲 [2] Velocity rating (Fibonacci)
Projects
No open projects
5 participants