Dropdown: Typing capital letters in an open noSearch dropdown does not focus a value

[s-werking]

Describe the bug
Typing a capital letter to select a value works when the dropdown is closed, but not when the dropdown is open. This happens on dropdowns with the noSearch option set to true.

To Reproduce
Steps to reproduce the behavior:

1. Go to http://localhost:4000/components/dropdown/example-no-search-lsf.html
2. Click on the top dropdown to open it
3. Type "T"
   Expected Result: "T - Thor" should be focused
   Actual Result: The blank option is focused

Expected behavior
When a capital letter is typed in an open dropdown with noSearch turned on, the corresponding option should receive focus just as it would when the lowercase letter is typed.

Version

• ids-enterprise: v.4.60.0-dev

Platform

• Infor Application/Team Name: lawson
• OS Version: Windows10
• Browser Name: chrome
• Browser Version: Version 97.0.4692.99 (Official Build) (64-bit)
  Related Lawson JIRA Ticket: LSF-50656

[tmcconechy]

Seems like it just happens the first time...

[awbuboltz]

Note, this is the second occurrence of this issue: #4757

[tmcconechy]

OK lets be sure to add a test to (who picks this up...)

[awbuboltz]

Hey team, this issue is causing a large majority of our tests to fail and makes it difficult to use our product. Any chance of it getting looked at sooner than later?

[tmcconechy]

Added to the sprint can you look when you can @ericangeles

[davidcarlsonberg]

Just attempted this on Windows10 Chrome and it worked as expected.
Steps below:

• Visit master-enterprise.demo.design.infor.com/components/dropdown/example-no-search-lsf.html
• Click on top dropdown arrow to open
• Press Shift + T
• Notice T - Thor is highlighted
  

[tmcconechy]

@davidcarlsonberg try it on https://main-enterprise.demo.design.infor.com/components/dropdown/example-no-search-lsf.html instead (master is old) or local

[tmcconechy]

Once we figure this out will patch in a 4.60.1

[awbuboltz]

@davidcarlsonberg, are you seeing it now on main-enterprise?

[davidcarlsonberg]

Yes, I can reproduce it now. It happens only the first time you click Shift + T on Windows10 Chrome after opening the No Search Dropdown.

[tmcconechy]

Great - do you think you can fix this before the end of the month @davidcarlsonberg ?

[davidcarlsonberg]

@tmcconechy I'll prioritize this over the weekend and have an update Monday.

[davidcarlsonberg]

Unfortunately, I'm unable to reproduce this using Browserstack. Can anyone else reproduce in that environment?

[s-werking]

Hi @davidcarlsonberg,

I used Browserstack and was able to reproduce on all browsers. Did you use the correct URL?
https://main-enterprise.demo.design.infor.com/components/dropdown/example-no-search-lsf.html

[tmcconechy]

Im not able to reproduce it either (never have) - but since the search is case insensitive anyways i wonder if this can be fixed by making both ends of the string lowerCase?

Do you have any suggestions for a fix @s-werking since you can see it clearly?

[davidcarlsonberg]

Yes, @s-werking , using the URL (https://main-enterprise.demo.design.infor.com/components/dropdown/example-no-search-lsf.html) I am unable to reproduce on Browserstack (Windows10, Chrome 98).

[s-werking]

It looks like this issue started happening after the noSearch dropdown input was disabled in: #5369

Without this line in dropdown.js, a capital letter is searched correctly, although a disabled search does make sense:
this.searchInput.prop('readonly', this.settings.noSearch);

The issue is that once it hits the line 1766 (self.highlightStartsWith(self.filterTerm);), self.filterTerm is the Shift key symbol and "t" when in branch 4.52.x self.filterTerm is just "t" for the case that "T" is entered in the dropdown search.

[s-werking]

Okay I may have found a possible fix. Let me know what you think @davidcarlsonberg @tmcconechy .

Line 1629 - Add '&& !self.isControl(key)' to the conditional

[s-werking]

of dropdown.js

[tmcconechy]

Can you try to push that - and then we just test out everything else on a PR @davidcarlsonberg and assume it fixes?

[jbrcna]

this issue is now resolved. moving this ticket to done. thanks
verified in https://main-enterprise.demo.design.infor.com/components/dropdown/example-no-search-lsf.html
BS Win 10 chrome 97