-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datepicker: allow the removal of masking via a new option #6080
Comments
Feel free @EdwardCoyle - I think just a setting to not invoke the mask seems entirely appropriate |
Note, this is team: lawson |
@tjamesallen15 two notes:
I think tasks for this issue are:
|
Hi @tmcconechy, would like to ask an estimate for the 4.61 release date, since we are contemplating on applying the workaround on our end in line with our own release date. It would be really helpful to us. Thanks! |
Would be march 5-10 (start of march) |
Once completed will patch in 4.60.1 |
this issue is now resolved. |
Is your feature request related to a problem or use case? Please describe.
In the past (pre-4.51), we were able to use
$elem.data('mask').destroy();
to effectively remove the masking from datepickers. That was an acceptable solution, but now that it's broken, we'd like to have something more permanently supported.Describe the solution you'd like
A new datpicker option called something like
{ "useMask": false }
that forgoes the addition of masking to the input field, allowing users to customize their own formatting.Describe alternatives you've considered
One temporary solution I found with @EdwardCoyle was to add
this.$elem.data('mask', null);
after the destroy() call, which comes after initializing a datepicker. The reason this works is becauseenterprise/src/components/datepicker/datepicker.js
Line 552 in 7be62f5
undefined
, allowing null to pass though. For some reason, the entire mask is being set back up on blur, which seems wrong altogether, that gets called here:enterprise/src/components/datepicker/datepicker.js
Line 287 in ed3870c
setCurrentCalendar()
after the blur.Additional context
Add any other context or screenshots about the feature request here.
And what application do you work on? [e.g. {Infor XYZ}]
Team: Lawson
Needed by: 4.61
@EdwardCoyle and I spent a good amount of time figuring this all out, so he's probably the guy for the job ;).
The text was updated successfully, but these errors were encountered: