Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale: 2 of sets of "month" strings are needed #6122

Closed
cpinatel7 opened this issue Feb 14, 2022 · 28 comments
Closed

Locale: 2 of sets of "month" strings are needed #6122

cpinatel7 opened this issue Feb 14, 2022 · 28 comments
Labels
focus: translation For translation issues type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@cpinatel7
Copy link

Locale: 2 of sets of "month" strings are needed

From linguists: "Names of months do take lowercase initial within a phrase/string, but not at the start like here. We need separate strings for such occurrences"

sv-SE-messages.js, for example, only contains the following string:
id: 'MonthWideFeb', value: 'Februari'

Do you automatically convert F to lowercase f?

image

Translations are maintained by Henry.Wondergem@infor.com

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Feb 14, 2022
@tmcconechy
Copy link
Member

tmcconechy commented Feb 14, 2022

No we just put the date in there that they give us. I think most of the cases will be like this in the calendar.
But they could also be in an input field or on a form.

We can provide two sets but we would need to understand the rules... I.E. when do we show the lower case ones and when do we show the upper case ones for each locale? And are some locales always upper case?

@tmcconechy tmcconechy added the focus: translation For translation issues label Feb 14, 2022
@cpinatel7
Copy link
Author

Linguists will determine whether it should be lowercase or uppercase based on the context provided in the associated comment:

@tmcconechy
Copy link
Member

Yes but we are using the same string in multiple places... So we would need to know which places to check or some general rule to get started?

@cpinatel7
Copy link
Author

Generic rules:

  1. At the start of a sentence/string e.g.
    image
    upper case is likely to be used in most languages
  2. Within a sentence/string e.g.
    image
    lower case is likely to be used in most languages

@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) and removed [2] Velocity rating (Fibonacci) labels Feb 14, 2022
@hwondergem
Copy link

@tmcconechy, will you add the other set based on the two contexts/generic rules as indicated by Christophe?

@tmcconechy
Copy link
Member

@hwondergem yes i will start by adding the strings too translate - may take a while to get them in the right places in the code. Can you send me an email with the server url again ? Unfortunately i lost it

@tmcconechy
Copy link
Member

tmcconechy commented Feb 17, 2022

@hwondergem @cpinatel7

Is this for both lengths of months? I.E.

February
Feb

Also for English will it be always February and Feb or is there cases where its lower case there?

@hwondergem
Copy link

@tmcconechy, I checked with our Lead Editor Roger:
"I don’t know of any specific instance where the short form is used as part of a longer string. But, if I saw one, I wouldn’t be surprised, and I wouldn’t think it was incorrect. Yes, English month names, long and short forms, always start with a capital."

@tmcconechy
Copy link
Member

@hwondergem put placeholders in en-messages.js in prep for this.

@stale
Copy link

stale bot commented Mar 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 8, 2023
@cpinatel7
Copy link
Author

Still required. Thanks

@stale stale bot removed the wontfix label Mar 8, 2023
@tmcconechy tmcconechy self-assigned this Mar 8, 2023
@tmcconechy
Copy link
Member

This may be fixed in the new web components. Will check soon.

@tmcconechy
Copy link
Member

https://main.wc.design.infor.com/ids-date-picker/example.html -> dont think this is fixed? But we do have two sets of strings now. Im just a little unclear when and where we should use them?

Is this specific to the date picker? Because we need to tell it which set to use and it can only use one set. So however it was translated in the longer string will appear.

Not sure how to verify this futher

@tmcconechy tmcconechy removed their assignment Mar 31, 2023
@cpinatel7
Copy link
Author

re: But we do have two sets of strings now

Could you please confirm?
One set with lowercase letters e.g. january, february, march, etc.
and
One set with uppercase letters e.g. January, February, March, etc.

What do the associated string comments say?

Thanks

@tmcconechy
Copy link
Member

Ok done. Added these here infor-design/enterprise-wc#1218 and on the server for translation. For some reason they were there but not in lower case.

But the problem is on the date picker https://main-enterprise.demo.design.infor.com/components/datepicker/example-index.html I can only show one or the other. I cant pick and choose to show lower case or upper case. So maybe we just translate the strings to the right case? Or i always show lower case?

@cpinatel7
Copy link
Author

For Date Picker, translations corresponding to the English uppercase set should be used.
re: Or i always show lower case?
No no no :).
In other cases, developers need to decide whether they want to use the uppercase set or lowercase set for English strings. Translations for these sets should be used accordingly. Strings / translations mustn't be converted from lower to uppercase or from upper to lowercase.
Thanks

@tmcconechy
Copy link
Member

OK, we could make it a setting. But how would they decide which one to use? (what would be the decision process?)

@cpinatel7
Copy link
Author

Depending on the context

Example:
image

Should the upper or lowercase set be used?
In this context, uppercase set is to be used in English. Translations corresponding to the English uppercase set should be used

@tmcconechy
Copy link
Member

OK, thats the current situation. https://main-enterprise.demo.design.infor.com/components/datepicker/example-index.html When would lower case be used?

@cpinatel7
Copy link
Author

Thanks

re: When would lower case be used?
Don't know but this should fix the following issue:

image

@tmcconechy
Copy link
Member

But thats what im saying. If we make two different strings in lower and upper case it wont automatically fix this. It will just show the upper case one. Unless we have specific rules of what languages are lower case. Or you just translate some strings in lower case and some in upper case of the original set of strings.

@cpinatel7
Copy link
Author

Please see below. The Swedish translation is value: 'Februari' but it's displayed as:

image

In English, lower 'f' is probably converted to upper 'F'. We don't want any automated conversion in any languages.

The uppercase set is to be used in English. Translations corresponding to the English uppercase set should be used too.

@tmcconechy
Copy link
Member

OK, so if i follow we can do this.

  • all strings are always as translated February -> whatever
  • we have a second set that as an option "can" be used by developers as a setting that shows it in lower case (not the default)

@cpinatel7
Copy link
Author

Yes, please. Thanks for your help

@tmcconechy
Copy link
Member

As of 4.84 the strings are availble if you need to use them. But we still use the default string in the code.

@cpinatel7
Copy link
Author

@tmcconechy
re: But we still use the default string in the code
I think this means that for Date Picker, you use the uppercase set for English. Could you please confirm?
Thanks

@tmcconechy
Copy link
Member

Yes we still use the uppercase english set. Then whatever thats gets translated to for each locale.

@cpinatel7
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: translation For translation issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

No branches or pull requests

3 participants