-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale: 2 of sets of "month" strings are needed #6122
Comments
No we just put the date in there that they give us. I think most of the cases will be like this in the calendar. We can provide two sets but we would need to understand the rules... I.E. when do we show the lower case ones and when do we show the upper case ones for each locale? And are some locales always upper case? |
Linguists will determine whether it should be lowercase or uppercase based on the context provided in the associated comment: |
Yes but we are using the same string in multiple places... So we would need to know which places to check or some general rule to get started? |
@tmcconechy, will you add the other set based on the two contexts/generic rules as indicated by Christophe? |
@hwondergem yes i will start by adding the strings too translate - may take a while to get them in the right places in the code. Can you send me an email with the server url again ? Unfortunately i lost it |
Is this for both lengths of months? I.E. February Also for English will it be always |
@tmcconechy, I checked with our Lead Editor Roger: |
@hwondergem put placeholders in en-messages.js in prep for this. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still required. Thanks |
This may be fixed in the new web components. Will check soon. |
https://main.wc.design.infor.com/ids-date-picker/example.html -> dont think this is fixed? But we do have two sets of strings now. Im just a little unclear when and where we should use them? Is this specific to the date picker? Because we need to tell it which set to use and it can only use one set. So however it was translated in the longer string will appear. Not sure how to verify this futher |
re: But we do have two sets of strings now Could you please confirm? What do the associated string comments say? Thanks |
Ok done. Added these here infor-design/enterprise-wc#1218 and on the server for translation. For some reason they were there but not in lower case. But the problem is on the date picker https://main-enterprise.demo.design.infor.com/components/datepicker/example-index.html I can only show one or the other. I cant pick and choose to show lower case or upper case. So maybe we just translate the strings to the right case? Or i always show lower case? |
For Date Picker, translations corresponding to the English uppercase set should be used. |
OK, we could make it a setting. But how would they decide which one to use? (what would be the decision process?) |
OK, thats the current situation. https://main-enterprise.demo.design.infor.com/components/datepicker/example-index.html When would lower case be used? |
But thats what im saying. If we make two different strings in lower and upper case it wont automatically fix this. It will just show the upper case one. Unless we have specific rules of what languages are lower case. Or you just translate some strings in lower case and some in upper case of the original set of strings. |
Please see below. The Swedish translation is value: 'Februari' but it's displayed as: In English, lower 'f' is probably converted to upper 'F'. We don't want any automated conversion in any languages. The uppercase set is to be used in English. Translations corresponding to the English uppercase set should be used too. |
OK, so if i follow we can do this.
|
Yes, please. Thanks for your help |
As of 4.84 the strings are availble if you need to use them. But we still use the default string in the code. |
@tmcconechy |
Yes we still use the uppercase english set. Then whatever thats gets translated to for each locale. |
Thanks |
Locale: 2 of sets of "month" strings are needed
From linguists: "Names of months do take lowercase initial within a phrase/string, but not at the start like here. We need separate strings for such occurrences"
sv-SE-messages.js, for example, only contains the following string:
id: 'MonthWideFeb', value: 'Februari'
Do you automatically convert F to lowercase f?
Translations are maintained by Henry.Wondergem@infor.com
The text was updated successfully, but these errors were encountered: