Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance File Upload - MAX files limit does not work - Change Error Icon #6229

Closed
inforandy opened this issue Mar 25, 2022 · 10 comments
Closed
Assignees
Labels
status: cant reproduce team: WFM For WFM Issues type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@inforandy
Copy link

Describe the bug
Observed behavior
files limit set to 20
[maxFiles]="maxFileCount"
readonly maxFileCount = 20;
if a batch of 20 files is dragged and dropped into the Adv. File Upload , the component throws mistakenly an error

To Reproduce
see above

Steps to reproduce the behavior:

Expected behavior
files should be able to be batch uploaded according to limit set by admin

see original submission here https://jira.infor.com/browse/UXD-4203

@tmcconechy tmcconechy added type: bug 🐛 [2] Velocity rating (Fibonacci) labels Mar 25, 2022
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Mar 25, 2022
@kevinwhitedesign
Copy link

There was also another slight design issue with it. I can't find the breadcrumb trail of where it was called out though.

  • The status icon should be switched from red X to an error icon
  • The message should be dismissible, to be consistent with the other file upload messages

Design example that had been created from this:
https://www.figma.com/file/fhvZFNoM63LUwJgve8ToJz/file-upload-error-fix?node-id=0%3A1

@tmcconechy tmcconechy added the team: WFM For WFM Issues label Mar 30, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.63.x (Apr 2022) Sprint via automation Mar 30, 2022
@tmcconechy tmcconechy changed the title Advance File Upload - MAX files limit does not work Advance File Upload - MAX files limit does not work - Change Error Icon Mar 30, 2022
@yohannahbautista
Copy link
Contributor

Hello, I tried reproducing the bug in this page: http://localhost:4000/components/fileupload-advanced/test-max-files.html
by changing maxFiles to 20 and I was able to upload

I also tried it in NG with this page: http://localhost:4200/ids-enterprise-ng-demo/fileupload-advanced
by updating the maxFiles following the steps posted above and I was able to upload

@tmcconechy
Copy link
Member

I was also not able to reproduce @inforandy can you get together with the WFM team that reported this and ask them how we can reproduce?

@kevinwhitedesign
Copy link

Think this is coming from ENrico Tomada

@tmcconechy
Copy link
Member

Does he have any github ID? Email? Anyways someone please point him here or we really cant do anything.

Thanks

@kevinwhitedesign
Copy link

https://jira.infor.com/browse/UXD-4203 I think the issue is here, maybe it shows more examples of the issue with the component?

@tmcconechy
Copy link
Member

tmcconechy commented Apr 7, 2022

Yeah but the problem is its a little vague and we cant reproduce any issues with it as far as we cant tell as described. So need a way to reproduce it.

We did fix the icon so its separate - but cant reproduce anything with 20 max files

@tmcconechy
Copy link
Member

Developer noted on the Jira that this is working now. Closing...

@ericangeles ericangeles moved this from To do to Ready for QA (beta) in Enterprise 4.63.x (Apr 2022) Sprint Apr 18, 2022
@janahintal
Copy link
Contributor

Hi @yohannahbautista, when I upload 2 or more files in https://main-enterprise.demo.design.infor.com/components/fileupload-advanced/example-failed.html then tick the 'set failed' button, only 1 file has the Error Message and close icon.

Expected: All files

@janahintal janahintal moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.63.x (Apr 2022) Sprint Apr 18, 2022
@tmcconechy
Copy link
Member

This probably ok - right @yohannahbautista as the API is just setting the first one (you can make the api set it on any specific one)

@tmcconechy tmcconechy moved this from Failed QA (beta) to Done in Enterprise 4.63.x (Apr 2022) Sprint Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: cant reproduce team: WFM For WFM Issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

No branches or pull requests

5 participants