Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Module: No difference in color between active and inactive tabs #6236

Closed
s-werking opened this issue Mar 28, 2022 · 4 comments · Fixed by #6245
Closed

Tabs Module: No difference in color between active and inactive tabs #6236

s-werking opened this issue Mar 28, 2022 · 4 comments · Fixed by #6245
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@s-werking
Copy link
Contributor

Describe the bug
When any color or theme has explicitly been assigned to the page, active tabs do not receive a different background color. This makes it hard to tell which tab is currently active.

To Reproduce

Steps to reproduce the behavior:

  1. Go to http://localhost:4000/components/tabs-module/example-category-searchfield-go-button-home.html
  2. Click on Tab 2
  3. Note that Tab 2 has a different background color than the rest of the tabs since it is active.
  4. Go to http://localhost:4000/components/tabs-module/example-category-searchfield-go-button-home.html?theme=new&mode=light&colors=606066
  5. Click on Tab 2
  6. Note that Tab 2 has the same background color as the rest of the tabs even though it is active

Expected behavior
It is expected that a selected tab would have a different background color than the rest of tabs to distinguish which tab is active.

Version

  • ids-enterprise: 4.60.2

Screenshots
When the theme and color are default:
No theme changes

When the theme and color are set:
With custom theme

Platform

  • Infor Application/Team Name: lawson
  • OS Version: Windows 11
  • Browser Name: chrome
  • Browser Version: 99.0.4844.84 (Official Build) (64-bit)
@tmcconechy tmcconechy added type: bug 🐛 [2] Velocity rating (Fibonacci) labels Mar 28, 2022
@awbuboltz
Copy link
Contributor

Note, this is the Lawson team.

@tmcconechy, any initial guesses on why this broke? We're right on the verge of release but this is kind of an ugly one, if the fix is simple we may try to get something in last minute.

@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Mar 29, 2022
@tmcconechy
Copy link
Member

Im not seeing that this broke. I can go back many versions to 4.54 (didnt try any further back) and still see the same thing https://4540-enterprise.demo.design.infor.com/components/tabs-module/example-category-searchfield-go-button?theme=new&mode=light&colors=606066

The problem i guess is because of a specific color 606066 or looks like personalization in general is not working on this pattern and not 100% sure if it every did.

https://4540-enterprise.demo.design.infor.com/components/tabs-module/example-category-searchfield-go-button?theme=new&mode=light&colors=80000

I'll can it in for next sprint...But it might be easy to fix (not 100% sure) if pressed for it later this week maybe...And you cant "not do that".

@awbuboltz
Copy link
Contributor

Looks like slightly further back it broke, it works in 4.52 but not 4.53 https://4520-enterprise.demo.design.infor.com/components/tabs-module/example-category-searchfield-go-button?theme=new&mode=light&colors=606066.

We came from 4.51 which is probably why we're seeing it.

@tmcconechy tmcconechy self-assigned this Mar 30, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.63.x (Apr 2022) Sprint via automation Mar 30, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.62.x (Mar 2022) Sprint via automation Mar 30, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.62.x (Mar 2022) Sprint Mar 30, 2022
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.62.x (Mar 2022) Sprint Apr 4, 2022
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants