Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid with validators and paging creates a toolbar and it is never removed #6290

Closed
AnaLauraMartinez opened this issue Apr 8, 2022 · 1 comment · Fixed by #6506
Closed
Assignees
Labels
type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@AnaLauraMartinez
Copy link

Describe the bug
Datagrid has validators and paging. When there is an error on the first page and the user goes to page 2 a toolbar appears with an error icon. When the user returns to page 1 and fixes the error, the error icon disappears but the toolbar remains.

To Reproduce
In a datagrid with paging and validators, datagrid doesn't have a toolbar, follow these steps:

  1. Enter invalid data, notice the cell is marked with an error icon but there is no toolbar
  2. Move to page 2, notice there is now a toolbar on the top with an error icon indicating there is an error on page 1
  3. User moves back to page 1, notice the toolbar still there with an error icon
  4. User fixes the error and the cell error icon disappeared, the toolbar is cleared from the error but the white space remains.

Expected behavior
Toolbar should disappear when the error is corrected

Version
"ids-enterprise-ng": "13.0.3"

Screenshots
image
image

Platform

  • Infor Application/Team Name: [e.g. Infor XYZ, Infor ABC]
  • Device: (if applicable) [e.g. iPhone 6 or Samsung Galaxy S6]
  • OS Version: [e.g. Windows 10 or iOS 8]
  • Browser Name: Chrome
  • Browser Version: [e.g. 22, 66.0.3359.181 (Official Build) (64-bit)]

When debugging the code that is adding the toobar is this and it doesn't remove it after the errors are cleared.
/**
* Show all non visible cell errors
* @Private
* @returns {void}
*/
showNonVisibleCellErrors: function showNonVisibleCellErrors() {
var _this19 = this;

  // Create empty toolbar
  if (!this.toolbar) {
    this.settings.toolbar = {
      title: ' '
    };
    this.appendToolbar();
  }
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.64.x (May 2022) Sprint
  
Ready for QA (beta)
Development

Successfully merging a pull request may close this issue.

4 participants