Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: allow product devs to add custom css class to event labels in calendar component #6304

Closed
edinfor opened this issue Apr 14, 2022 · 7 comments · Fixed by #6305
Closed
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@edinfor
Copy link
Contributor

edinfor commented Apr 14, 2022

Is your feature request related to a problem or use case? Please describe.
A clear and concise description of what the problem is. [e.g. {Component Name} has a problem when {...}]

New release has removed custom classes from getting passed into event label in calendar component, thus broke some of the pages that requires customization.

Please refer to code here:
74d508d

Describe the solution you'd like
A clear and concise description of what you want to happen. [e.g. {Component Name} would work better if {...}]
As per discussion with Tim, I would like to suggest that we add an additional event attribute "cssClass" to allow product devs to add custom class names.
https://github.com/infor-design/enterprise/blob/4.62.0/src/components/calendar/calendar.js#L824

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Might need to write jQuery hacks to add css classes to each event label if we cannot allow this solution.

Additional context
Add any other context or screenshots about the feature request here.
And what application do you work on? [e.g. {Infor XYZ}]

@edinfor edinfor changed the title allow product devs to add custom css class to event labels in calendar component Calendar: allow product devs to add custom css class to event labels in calendar component Apr 14, 2022
@tmcconechy tmcconechy added type: bug 🐛 [2] Velocity rating (Fibonacci) labels Apr 14, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.63.x (Apr 2022) Sprint via automation Apr 14, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.63.x (Apr 2022) Sprint Apr 14, 2022
@CindyMercadoReyes CindyMercadoReyes moved this from Pending Review to Ready for QA (beta) in Enterprise 4.63.x (Apr 2022) Sprint Apr 14, 2022
@edinfor
Copy link
Contributor Author

edinfor commented Apr 19, 2022

@tmcconechy can I please have a version + angular version that includes this for testing? Next release is too far away...some of the features we are developing is blocked by this. thanks!

@tmcconechy
Copy link
Member

ok @edinfor try dev release ids-enterprise-ng: 13.4.0-dev.20220419

@edinfor
Copy link
Contributor Author

edinfor commented Apr 19, 2022

will you be able to release a fix version such as 13.4.1 that drops the dev tag? it may sound a little unofficial to PMs, we recently upgraded our stack to angular 13, teams are really looking forward to align with all the latest changes with IDS, many of them need the new features for development... really really appreciate your time!

@tmcconechy
Copy link
Member

No not yet as really not enough done and tested to call it official. But what i could do is patch this issue in the old release but you would only get the one fix? Does that work?

@edinfor
Copy link
Contributor Author

edinfor commented Apr 20, 2022

No not yet as really not enough done and tested to call it official. But what i could do is patch this issue in the old release but you would only get the one fix? Does that work?

yes! that will definitely do it!

@tmcconechy
Copy link
Member

ok i made a 4.62.1 with this fix and corresponding 13.3.2

@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.63.x (Apr 2022) Sprint Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants