Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cards: group-action misaligned filter icon #6346

Closed
jbrcna opened this issue Apr 26, 2022 · 3 comments · Fixed by #6350
Closed

Cards: group-action misaligned filter icon #6346

jbrcna opened this issue Apr 26, 2022 · 3 comments · Fixed by #6350
Assignees
@ericangeles
Labels
priority: high type: regression bug ↩️ [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.63.x (Apr 2022) Sprint

Comments

@jbrcna
Copy link
Contributor

jbrcna commented Apr 26, 2022

Describe the bug
filter icon is not aligned

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://main-enterprise.demo.design.infor.com/components/cards/example-group-action.html?
  2. Select some items
  3. See error
  4. Try also in classic theme

Expected behavior
filter icon should be aligned

Version

  • ids-enterprise:v4.63.0-dev

Screenshots
image

Platform
All

Additional context
Add any other context about the problem here.
@tmcconechy tmcconechy added this to To do in Enterprise 4.63.x (Apr 2022) Sprint via automation Apr 26, 2022
@tmcconechy
Copy link
Member

this too should probably be fixed soon @ericangeles

@ericangeles ericangeles self-assigned this Apr 26, 2022
@ericangeles
Copy link
Contributor

I think it has something to do with this PR #6309

Just need to specify the correct display value. E.g.,

If it's contextual-toolbar, it should be block. And if it's flex-toolbar ONLY, it should be flex.

@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.63.x (Apr 2022) Sprint Apr 26, 2022
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.63.x (Apr 2022) Sprint Apr 26, 2022
@ericangeles ericangeles mentioned this issue Apr 26, 2022
Merged
1 task
@ericangeles ericangeles moved this from Pending Review to Ready for QA (beta) in Enterprise 4.63.x (Apr 2022) Sprint Apr 27, 2022
@jbrcna
Copy link
Contributor Author

jbrcna commented Apr 28, 2022

QA Passed. v4.63.0-dev
https://main-enterprise.demo.design.infor.com/components/cards/example-group-action.html
image

https://main-enterprise.demo.design.infor.com/components/listview/test-multiselect-flex.html
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.63.x (Apr 2022) Sprint Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
priority: high type: regression bug ↩️ [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.63.x (Apr 2022) Sprint
  
Done
Milestone
No milestone
3 participants
@tmcconechy @ericangeles @jbrcna