Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinkpage: Datagrid Personalized Columns Search the X icon is a bit off #6375

Closed
iamjamesreyracho opened this issue May 4, 2022 · 5 comments · Fixed by #6371 or #6432
Closed

Sinkpage: Datagrid Personalized Columns Search the X icon is a bit off #6375

iamjamesreyracho opened this issue May 4, 2022 · 5 comments · Fixed by #6371 or #6432
Assignees
@ericangeles
Labels
priority: trival Least important issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.64.x (May 2022) Sprint

Comments

@iamjamesreyracho
Copy link
Contributor

iamjamesreyracho commented May 4, 2022 •
edited

Describe the bug
The X icon in the search field is a bit off in both new and classic version.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://4630-beta0-enterprise.demo.design.infor.com/#
  2. Scroll down to Datagrid
  3. Click the triple dot (...), then click Personalized Columns
  4. Input a text
  5. See error

Expected behavior
X icon should looks fine.

Version

  • ids-enterprise: v4.63.0-beta.0

Screenshots
image
New
image
Classic

Platform

  • Browser Name: Chrome (Version 101.0.4951.54 (Official Build) (64-bit))

Additional context
NA
@ericangeles ericangeles added type: bug 🐛 priority: trival Least important issues [2] Velocity rating (Fibonacci) labels May 4, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.64.x (May 2022) Sprint via automation May 4, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.64.x (May 2022) Sprint May 4, 2022
@tmcconechy
Copy link
Member

Lets test this again after merging... #6371
I didnt test but might be fixed @ericangeles ?

@ericangeles
Copy link
Contributor

@tmcconechy I reproduced it on my searchfield branch.

@ericangeles
Copy link
Contributor

The only thing here is the padding on the right side of the close icon.

@ericangeles ericangeles self-assigned this May 4, 2022
@ericangeles ericangeles mentioned this issue May 4, 2022
Merged
2 tasks
@ericangeles ericangeles moved this from Pending Review to Ready for QA (beta) in Enterprise 4.64.x (May 2022) Sprint May 6, 2022
@iamjamesreyracho
Copy link
Contributor Author

Still need to fix the x button in Classic Version, kindly see test evidences below:
New - Passed
image

Classic -Failed
image

@iamjamesreyracho iamjamesreyracho moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.64.x (May 2022) Sprint May 12, 2022
@ericangeles ericangeles moved this from Failed QA (beta) to In progress in Enterprise 4.64.x (May 2022) Sprint May 16, 2022
@ericangeles ericangeles mentioned this issue May 17, 2022
Merged
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.64.x (May 2022) Sprint May 17, 2022
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.64.x (May 2022) Sprint May 17, 2022
@iamjamesreyracho
Copy link
Contributor Author

QA Passed. Moving this ticket to done. Thanks.
Classic
image

@iamjamesreyracho iamjamesreyracho moved this from Ready for QA (beta) to Done in Enterprise 4.64.x (May 2022) Sprint May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
priority: trival Least important issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.64.x (May 2022) Sprint
  
Done
Milestone
No milestone
3 participants
@tmcconechy @ericangeles @iamjamesreyracho