Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Dark theme's brand.primary.base hex color is wrong #6446

Closed
Sovia opened this issue May 18, 2022 · 7 comments · Fixed by #6461
Closed

Theme: Dark theme's brand.primary.base hex color is wrong #6446

Sovia opened this issue May 18, 2022 · 7 comments · Fixed by #6461
Assignees
Labels
focus: dark mode dark mode team: landmark For Landmark issues type: bug 🐛 type: patch [2] Velocity rating (Fibonacci)

Comments

@Sovia
Copy link
Contributor

Sovia commented May 18, 2022

Describe the bug
The theme service's personalization color's has the wrong hex value for it's brand.primary.base option, which leads a dropdown allowing the choice of color to show the wrong default preview color.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://main-enterprise.demo.design.infor.com/components/personalize/example-color-theme-api.html?theme=new&mode=dark
  2. See that the "default" option is selected in the second dropdown, with a blue preview color next to the label. This is incorrect, since the actual default is a slate color. The preview color should match what the default color for the header is.

Expected behavior
The correct default color should be seen

Version

  • ids-enterprise: v4.62.0

Screenshots
image

Platform

  • All

Additional context
Just need to update theme-classic-dark-colors.json and theme-new-dark-colors.json to have the correct hex values for their brand.primary.base objects.

@tmcconechy tmcconechy added type: bug 🐛 [2] Velocity rating (Fibonacci) team: landmark For Landmark issues labels May 18, 2022
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation May 18, 2022
@Sovia Sovia changed the title Personalization: Dark theme's brand.primary.base hex color is wrong Theme: Dark theme's brand.primary.base hex color is wrong May 18, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.64.x (May 2022) Sprint via automation May 18, 2022
@tmcconechy
Copy link
Member

tmcconechy commented May 18, 2022

@ericangeles - can one of you guys take a look here. I'll patch it to 4.62 and 4.63 once complete

@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.64.x (May 2022) Sprint May 19, 2022
@ericangeles ericangeles self-assigned this May 19, 2022
@ericangeles
Copy link
Contributor

@tmcconechy so the fix on this will be on identity tokens?

@tmcconechy
Copy link
Member

I think the tokens for this are a bit out of sync so not sure what will be the impact to would be to change them. I'll send you a test package (rather big).

A possible safer fix seems to be to use the sass variables.

i.e.

.primary-bg-color {
  background: $header-bg-color;
}

@ericangeles
Copy link
Contributor

PR for this issue infor-design/design-system#491

@tmcconechy
Copy link
Member

@ericangeles - did you test my fix? If so i can help finish this one up if you give me the go?

@ericangeles
Copy link
Contributor

Yes I did, Tim. It works.

@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.64.x (May 2022) Sprint May 23, 2022
@ericangeles ericangeles moved this from Pending Review to Ready for QA (beta) in Enterprise 4.64.x (May 2022) Sprint May 25, 2022
@jbrcna
Copy link
Contributor

jbrcna commented May 26, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: dark mode dark mode team: landmark For Landmark issues type: bug 🐛 type: patch [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants