Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: escapes special chars in the cellchange event #8516

Closed
whernebrink opened this issue Mar 5, 2024 · 3 comments · Fixed by #8520
Closed

Datagrid: escapes special chars in the cellchange event #8516

whernebrink opened this issue Mar 5, 2024 · 3 comments · Fixed by #8520
Assignees

Comments

@whernebrink
Copy link

Describe the bug
In prior issue it was fixed so that when entering special chars into editable fields wasn't escaped, however, the event object for cellchange event still have it

To Reproduce

Steps to reproduce the behavior:

  1. Go to example-editable
  2. Open console
  3. Enter related[BALMAS1("TX60:\{IndexList_Items.TX60}")] into e.g. an activity column
  4. See logged event object which has an additional \ for the value prop, rowData.activity prop, as well as oldValue prop still escapes special chars related[BALMAS1("TX60:\{IndexList_Items.TX60}")]

Expected behavior
All mentioned props should be exactly the same as the inputted string, related[BALMAS1("TX60:\{IndexList_Items.TX60}")].

Version

  • ids-enterprise: 4.90.1 (here the values are still being escaped on the event object), but also latest.
  • ids-enterprise-ng: 17.1.3 (we're currently on this one and need a patch with only the change from this version)

Platform

  • Infor Application/Team Name: M3
@tmcconechy
Copy link
Member

@ericangeles can you or @yohannahbautista take a look? maybe it is as simple as calling the unescape on the variables in the events?

@whernebrink
Copy link
Author

Due to the time frame we have, I've tried the following workaround on our side which we will have to go with for the April release:

const value = Soho.xss.unescapeHTML(rowData.initialValue);

Would be great if the fix can be included in next ids-enterprise-ng version (and we'll try to update for June release), but you don't have to do any other patch for now @tmcconechy.

Thanks everyone!

@tmcconechy
Copy link
Member

ok thanks @whernebrink we will just include in the regular release cycle.I was going to say at one point you could run it on the event data this way 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants