-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to return the flair entity types in the response body #4
Comments
If the API is still compatible with Gerbil while returning extra fields in the response, I would just make this the default to be honest. No reason to make this optional when the entity type is available anyway, at least in the case where the default NER from Flair is being used. I suppose a custom NER model might only do mention detection without types, but even in that case we could just return a standard I could add this if @hasibi / @mickvanhulst agree (and can tell me if extra fields matter for Gerbil)? |
I would agree with this. Next to changing the fields in our Python code, we would also need to change the Gerbil middleware. At the moment this is expecting a certain JSON response, so if we can make it so that it ignores the remainder of the unnecessary fields, we are already there :). Would be nice if you could work on this @KDercksen ! |
I don't have rights to close the issue myself, but I think this is done :) |
add entity tag info to response (see #4)
FLAIR labels the detected mentions with an entity type. We could return these "for free", instead of requiring an extra join against DBPedia / Wikidata.
The text was updated successfully, but these errors were encountered: