Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source code information is sometimes tracked incorrectly #41

Closed
konnov opened this issue May 16, 2019 · 3 comments
Closed

Source code information is sometimes tracked incorrectly #41

konnov opened this issue May 16, 2019 · 3 comments
Assignees
@konnov @Kukovec
Labels
bug
Milestone
backlog2020

Comments

@konnov
Copy link
Contributor

konnov commented May 16, 2019 •
edited

As type checker is using SourceStore when reporting errors, we have to fix SpecHandler (or whatever unfolds the definitions) to properly track the source code. In the current version, the messages by the type checker are absolutely useless.
@konnov konnov added this to the BMCMT-0.6-refactoring milestone May 16, 2019
@konnov
Copy link
Contributor Author

konnov commented Aug 11, 2019

The new code that uses TransformationTracker has improved the situation. However, some expressions are still not tracked back.

@konnov konnov removed the high prio label Dec 7, 2019
@konnov konnov modified the milestones: BMCMT-0.6-release-refactoring, BMCMT-0.9-release-ux Dec 7, 2019
@konnov konnov changed the title Source code information is broken Source code information is sometimes tracked incorrectly Dec 7, 2019
@konnov konnov self-assigned this Dec 7, 2019
konnov added a commit that referenced this issue May 15, 2020
@konnov
closes #41, closes #112
abeaf82
@konnov
Copy link
Contributor Author

konnov commented May 15, 2020

Added SourceLocator.checkConsistency. It finds all subexpressions that are missing source info. As this method is expensive, it is only called in --debug mode. Consistency is checked after the parser pass and the preprocessing pass.

@konnov konnov closed this as completed May 15, 2020
@konnov
Copy link
Contributor Author

konnov commented May 15, 2020

abeaf82 fixes several bugs related to #41

Kukovec pushed a commit that referenced this issue Jun 26, 2020
@konnov
closes #41, closes #112
71915fb
@konnov konnov modified the milestones: v1.0-release-ux, backlog2020 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konnov konnov

@Kukovec Kukovec

Labels
bug
Projects
None yet
Milestone
backlog2020
Development

No branches or pull requests
2 participants
@konnov @Kukovec