Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing to custom rundir #1119

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Conversation

shonfeder
Copy link
Contributor

@shonfeder shonfeder commented Nov 22, 2021

The previous code wasn't actually writing to the expected files, it was
just creating the writer!

馃う

Closes informalsystems/apalache-tests#76

  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Entry added to UNRELEASED.md for any new functionality

Shon Feder added 3 commits November 22, 2021 16:20
The previous code wasn't actually writing to the expected files, it was
just creating the writer!
@shonfeder
Copy link
Contributor Author

Sorry for the error here.

I think my slight refactor helps make a future error of this sort less likely?

@shonfeder shonfeder enabled auto-merge (squash) November 22, 2021 21:27
@shonfeder
Copy link
Contributor Author

Gonna force this through, cause it's a trivial fix, and will unblock the benchmark fix that's pending.

@shonfeder shonfeder merged commit 2f258d0 into unstable Nov 22, 2021
@shonfeder shonfeder deleted the shon/fix-writing-to-run-dir branch November 22, 2021 22:27
@apalache-bot apalache-bot mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Benchmarks are not reporting SMT clauses or arena cells
1 participant