Factor out the injectorFactory #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tiny refactor is just some incidental cleanup on the CLI plumbing. - It removes the `injectorFacotry` - It reorders the arguments to `handleExceptions` In the current state of the code, the injectorFactory looks like it's just adding unhelpful indirection. Removing it allows us to save about 10 lines of code and remove an unreachable throw. The arguments to `handleExceptions` are reordered to reflect the the underlying logic better. I.e., we call the `runner` on the `injector` and `cmd`, so the `runner` is now supplied first.
shonfeder
force-pushed
the
shon/refactor-injectory-factory
branch
from
dd11c0b
to
315bebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny refactor is just some incidental cleanup on the CLI plumbing.
injectorFacotryhandleExceptionsIn the current state of the code, the injectorFactory looks like it's
just adding unhelpful indirection. Removing it allows us to save about
10 lines of code and remove an unreachable throw.
The arguments to
handleExceptionsare reordered to reflect the theunderlying logic better. I.e., we call the
runneron theinjectorand
cmd, so therunneris now supplied first.make fmt-fix(or had formatting run automatically on all files edited)