Fix build config to allow skipping tests #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51228a had the unintended consequence of triggering the maven/surefire design bug reported in https://issues.apache.org/jira/browse/MJAR-138. The effect of this was to break some of our build targets that skip tests by setting `maven.test.skip=true`, because it would not build the tlair jar when tests were skipped, but would then still require that the jar be present to compile. This fix implemented the workaround described at https://issues.apache.org/jira/browse/MJAR-138?focusedCommentId=16160394&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16160394 -- namely, we add a maven profile that only includes the dependency when `mavne.test.skip=false`.
shonfeder
force-pushed
the
sf/1219/fix-maven-skip-tests
branch
from
4e9e686
to
f135785
Compare
konnov
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1219
51228a7 had the unintended consequence of triggering the maven/surefire
design bug reported in https://issues.apache.org/jira/browse/MJAR-138.
The effect of this was to break some of our build targets that skip
tests by setting
maven.test.skip=true, because it would not build thetlair jar when tests were skipped, but would then still require that the
jar be present to compile.
This fix implemented the workaround described at
https://issues.apache.org/jira/browse/MJAR-138?focusedCommentId=16160394&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16160394
-- namely, we add a maven profile that only includes the dependency when
mavne.test.skip=false.