Fix conversion of quint indices operator #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
force-pushed
the
2509/quint/fix-indices
branch
from
c3a3b1c
to
1ae5754
Compare
|
I've tested this in quint integration tests to ensure the logic is correct too. |
Codecov Report
@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
- Coverage 78.48% 78.48% -0.01%
==========================================
Files 441 441
Lines 15484 15493 +9
Branches 2498 2486 -12
==========================================
+ Hits 12152 12159 +7
- Misses 3332 3334 +2
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Found a bug with empty lists. addressing now. |
added 2 commits
March 29, 2023 14:15
I was forgetting to special case construction of empty lists.
|
Fixed empty lists. |
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2509
Since quint lists are 0-indexed, we need to adjust the indices produced by
DOMAIN.make fmt-fix(or had formatting run automatically on all files edited)./unreleased/for any new functionality