Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize identifiers when pretty printing #2860

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

shonfeder
Copy link
Contributor

Closes #2858


  • Tests added for any new code
  • Ran make fmt-fix (or had formatting run automatically on all files edited)
  • Documentation added for any new functionality
  • Entries added to ./unreleased/ for any new functionality

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.90%. Comparing base (456a572) to head (efb30ea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
+ Coverage   78.88%   78.90%   +0.02%     
==========================================
  Files         467      467              
  Lines       15959    15963       +4     
  Branches     2592     2589       -3     
==========================================
+ Hits        12589    12596       +7     
+ Misses       3370     3367       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bugarela bugarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shonfeder shonfeder merged commit 291027c into main Mar 19, 2024
10 checks passed
bugarela added a commit that referenced this pull request Mar 19, 2024
…anitization

Add CHANGELOG entry for new sanitization from #2860
@apalache-bot apalache-bot mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty printing the apalache IR into TLA+ does not sanitize identifiers
3 participants