Suggested tweaks to the supported features docs #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
commented
May 3, 2021
docs/src/apalache/features.md
Outdated
| @@ -62,7 +62,7 @@ Operator | Supported? | Milestone | Comment | |||
| `f[e]` | ✔ | - | | |||
| `DOMAIN f` | ✔ | - | | |||
| `[ x \in S ↦ e]` | ✔ | - | | |||
| `[ S -> T ]` | ✔ | - | Sometimes, the functions sets are expanded | |||
| `[ S -> T ]` | ✔ | - | Sometimes, the functions sets are expanded <!-- What does this mean? --> | |||
There was a problem hiding this comment.
I don't know what this comment is supposed to mean or what the impact is on users.
There was a problem hiding this comment.
It is confusing. It means that in some cases functions sets are treated purely symbolically, but sometimes the model checker would try to construct an explicit set of functions, which is exponential. Actually, the model checker would just fail there and will not try to construct such a set. So this sentence is not helping the user.
There was a problem hiding this comment.
Cool. That helps. How about
Supported, provided the function can be interpreted symbolically
konnov
approved these changes
May 4, 2021
Co-authored-by: Igor Konnov <igor@informal.systems>
Co-authored-by: Igor Konnov <igor@informal.systems>
shonfeder
force-pushed
the
shon/manual/feature-tweaks
branch
from
809a9ee
to
66baeac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clarifications and slight rewording on the documentation of supported features.
There are also two places where I am not sure what is meant, I'll call those out with comments.