test trace command: execute a trace against testnet
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-kuprianov
force-pushed
the
andrey/trace
branch
from
f836e2f
to
9584882
Compare
rnbguy
reviewed
Jul 28, 2022
atomkraft/test/trace.py
Outdated
Comment on lines
9
to
17
| trace_test_stub = """ | ||
| from modelator.pytest.decorators import itf | ||
|
|
||
| pytest_plugins = "{0}" | ||
|
|
||
| @itf("{1}", keypath="{2}") | ||
| def test_trace(): | ||
| print("Successfully executed trace {1}") | ||
| """ |
There was a problem hiding this comment.
💯 for this!
but best to make the variable name capitalize because it is a constant.
rnbguy
reviewed
Jul 28, 2022
Comment on lines
+42
to
+47
| test_name = ( | ||
| test_name.replace("/", "_") | ||
| .replace(".", "_") | ||
| .replace(":", "_") | ||
| .replace("-", "_") | ||
| ) |
There was a problem hiding this comment.
I think you're trying to convert test_name to a valid snake case. You can use the case-converter package here 🙂
There was a problem hiding this comment.
I've tried it. snakecase produces this
test_tracesexample0itfjson_2022_07_28t104954601.py
instead of this
test_traces_example0_itf_json_2022_07_28T10_49_54_601.py
The latter I believe is more readable; so let's leave it as is for now.
atomkraft/test/trace.py
Outdated
| print(f"Writing {test_name} ...") | ||
| test.write( | ||
| trace_test_stub.format( | ||
| str(reactor).replace("/", ".").replace(".py", ""), trace, keypath |
There was a problem hiding this comment.
you can use .removesuffix(".py") instead of .replace(".py", "").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
This PR implements
atomkraft test tracecommandtraceoption is required now, until Store and retrieve the last model trace #55 is implementedtestsdirThis PR leaves for future work: