Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store test data with report #84

Merged
merged 5 commits into from
Aug 26, 2022
Merged

Store test data with report #84

merged 5 commits into from
Aug 26, 2022

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Aug 12, 2022

Closes #65

@rnbguy rnbguy requested a review from a team August 12, 2022 17:02
@rnbguy rnbguy self-assigned this Aug 12, 2022
rnbguy
rnbguy commented Aug 12, 2022
View reviewed changes
atomkraft/test/trace.py Outdated Show resolved Hide resolved
hvanz
hvanz reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@hvanz hvanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run test trace in the transfer example and it generates the expected files, except that log.txt is empty. Also I have a suggestion for moving the report-related code to a separate function.

atomkraft/test/trace.py Show resolved Hide resolved
atomkraft/test/trace.py Outdated Show resolved Hide resolved
atomkraft/test/trace.py Show resolved Hide resolved
@hvanz
Copy link
Member

hvanz commented Aug 26, 2022

Looks good. Go ahead and merge when you are ready.

@rnbguy rnbguy merged commit 8da1cb3 into dev Aug 26, 2022
@rnbguy rnbguy deleted the rano/store_report branch November 12, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvanz hvanz hvanz left review comments

Assignees

@rnbguy rnbguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store and report results for test trace
2 participants
@rnbguy @hvanz