Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ChainHandle deps for ChannelHandshakePayloadBuilder #231

Closed

Conversation

thaodt
Copy link

@thaodt thaodt commented Apr 2, 2024

Apart of #214 .

Description

Following the pattern to reduce ChainHandle dependency for ChannelHandshakePayloadBuilder.


PR checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

@thaodt thaodt changed the title remove ChainHandle deps in ChannelHandshakePayloadBuilder remove ChainHandle deps for ChannelHandshakePayloadBuilder Apr 2, 2024
@thaodt thaodt force-pushed the feat/ccc-chainhandle-depremoval-1 branch from ed6a175 to 867cc46 Compare April 17, 2024 03:41
@thaodt
Copy link
Author

thaodt commented May 23, 2024

close in favor of the hard work of team on refactoring the payload builders to generalize the implementation.
Ref: #214

@thaodt thaodt closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant