You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gm start gm hermes config gm hermes keys gm hermes cc
Copy paste the commands and append --new-client-connection --yes
Once the channels are open gm stop ibc-0 hermes query channels --chain ibc-0 // Produces the INFO error. Actually, creating the channels is not required to obtain the error. hermes tx raw ft-transfer --dst-chain ibc-0 --src-chain ibc-1 --src-port transfer --src-channel channel-0 --amount 1000Produces the INFO error as well.
Acceptance Criteria
Commands that fail because of a stopped node correctly log an ERROR log.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate milestone (priority) applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
I think this has to do with the fact that there are separating reporting mechanisms being used here. Running hermes keys add --chain ibc-0 --key-file file_that_does_not_exist.json outputs
2022-07-19T18:10:57.561844Z INFO ThreadId(01) using default configuration from '/Users/seanchen/.hermes/config.toml'
Error: A key with name 'wallet' already exists
It looks like the INFO log pertains to the using default configuration... message, while the Error on the next line seems to be an error related to the command itself.
The INFO and ERROR logs that are color coded are outputted by info!() and error! macro calls in the code. The non-color coded Error is actually using a separate Output::error() method that is defined in relayer-cli/src/conclude.rs. This is a custom module for outputting JSON return messages and is orthogonal to the macros that I mentioned.
It does make the output a bit confusing, especially because the output from the conclude module is less apparent in the logs, but I'm not sure how they could be consolidated.
Summary of Bug
After stopping a node, every command should fail with an
ERROR
log. The error is currently wrapped within anINFO
log :I meet the same problem with transfers.
Version
hermes 1.0.0-rc.0
gm 0.1.3
Steps to Reproduce
Using
gm
and this gm.toml :gm start
gm hermes config
gm hermes keys
gm hermes cc
Copy paste the commands and append
--new-client-connection --yes
Once the channels are open
gm stop ibc-0
hermes query channels --chain ibc-0
// Produces the INFO error. Actually, creating the channels is not required to obtain the error.hermes tx raw ft-transfer --dst-chain ibc-0 --src-chain ibc-1 --src-port transfer --src-channel channel-0 --amount 1000
Produces the INFO error as well.Acceptance Criteria
Commands that fail because of a stopped node correctly log an ERROR log.
For Admin Use
The text was updated successfully, but these errors were encountered: