Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce datagram domain type #288

Closed
2 of 4 tasks
adizere opened this issue Oct 6, 2020 · 2 comments
Closed
2 of 4 tasks

Introduce datagram domain type #288

adizere opened this issue Oct 6, 2020 · 2 comments
Labels
I: dependencies Internal: related to dependencies O: code-hygiene Objective: cause to improve code hygiene O: new-feature Objective: cause to add a new feature or support
Milestone

Comments

@adizere
Copy link
Member

adizere commented Oct 6, 2020

Summary of Bug

We currently use the term "message" to refer to the various data types that IBC handlers consume. We should consider introducing "datagram" to replace "messages", as a more accurate term (also reflecting the ICS specs more closely).

Note that this issue depends on coordinating with external teams, namely we should probably get input from the spec team (cosmos/ics) and SDK team to ensure that the "datagram" vs. "message" disambiguation is consistent across teams.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added O: new-feature Objective: cause to add a new feature or support A: good-first-issue Admin: good for newcomers O: code-hygiene Objective: cause to improve code hygiene labels Oct 6, 2020
@adizere adizere added this to the v0.0.7 milestone Oct 6, 2020
@adizere adizere added modules I: dependencies Internal: related to dependencies and removed A: good-first-issue Admin: good for newcomers modules labels Nov 6, 2020
@adizere adizere mentioned this issue Nov 9, 2020
42 tasks
@adizere
Copy link
Member Author

adizere commented Nov 19, 2020

Another improvement we can throw into the same bucket with datagrams is the naming practice around our serialization types:

Looking at the code now that this new Protobuf type is kicking in, I'm wondering if we should not adapt our practice of calling serialization types with the "Raw" prefix. Instead, we could use the "Proto" prefix or something similar. So for example we'd have the following:

impl Protobuf<ProtoClientConnections> for ConnectionIds {}

The idea is to make the connection between tendermint_proto::Protobuf and the underlying type more explicit. It's mostly aesthetics, but might make the codebase simpler to read & understand.

Originally posted by @adizere in #364 (comment)

@adizere
Copy link
Member Author

adizere commented Jan 6, 2022

Closing as outdated. The "datagram" term never took off as part of the IBC ecosystem (SDK/ibc-go/go-rly/etc).

The suggestion in this comment is a nice to have, but unclear what/if it solves any issue.

@adizere adizere closed this as completed Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: dependencies Internal: related to dependencies O: code-hygiene Objective: cause to improve code hygiene O: new-feature Objective: cause to add a new feature or support
Projects
None yet
Development

No branches or pull requests

2 participants