Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better type conversion into Height #300

Closed
4 tasks done
adizere opened this issue Oct 9, 2020 · 0 comments · Fixed by #301
Closed
4 tasks done

Better type conversion into Height #300

adizere opened this issue Oct 9, 2020 · 0 comments · Fixed by #301
Assignees
@adizere
Labels
I: dependencies Internal: related to dependencies O: code-hygiene Objective: cause to improve code hygiene
Milestone
v0.0.4

Comments

@adizere
Copy link
Member

adizere commented Oct 9, 2020

Summary

Following the fix for Height conversion in tenderming-rs -- informalsystems/tendermint-rs#628 -- we should adapt our code to use the same conventions (and avoid unwraps).

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added work in progress I: dependencies Internal: related to dependencies O: code-hygiene Objective: cause to improve code hygiene labels Oct 9, 2020
@adizere adizere added this to the v0.0.5 milestone Oct 9, 2020
@adizere adizere self-assigned this Oct 9, 2020
This was referenced Oct 9, 2020
Merged
Merged
@adizere adizere modified the milestones: v0.0.5, v0.0.4 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adizere adizere

Labels
I: dependencies Internal: related to dependencies O: code-hygiene Objective: cause to improve code hygiene
Projects
None yet
Milestone
v0.0.4
Development

Successfully merging a pull request may close this issue.

Avoid unwrap() for Height conversion informalsystems/hermes
1 participant
@adizere