Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for latest tendermint-rs master #299

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Conversation

romac
Copy link
Member

@romac romac commented Oct 9, 2020

Closes: #XXX

Description

Fix build for latest tendermint-rs master.


For contributor use:

  • Unit tests written
  • Added test to CI if applicable
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@codecov-io
Copy link

Codecov Report

Merging #299 into master will increase coverage by 23.3%.
The diff coverage is 61.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #299      +/-   ##
=========================================
+ Coverage    13.6%   37.0%   +23.3%     
=========================================
  Files          69     120      +51     
  Lines        3752    7789    +4037     
  Branches     1374    2786    +1412     
=========================================
+ Hits          513    2887    +2374     
- Misses       2618    4588    +1970     
+ Partials      621     314     -307     
Impacted Files Coverage Δ
modules/src/events.rs 0.0% <0.0%> (ø)
modules/src/ics02_client/events.rs 0.0% <ø> (ø)
modules/src/ics02_client/raw.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/context.rs 0.0% <0.0%> (ø)
modules/src/ics03_connection/error.rs 16.6% <0.0%> (-16.7%) ⬇️
modules/src/ics04_channel/error.rs 75.0% <ø> (+50.0%) ⬆️
modules/src/ics04_channel/packet.rs 0.0% <0.0%> (ø)
modules/src/ics07_tendermint/client_def.rs 0.0% <0.0%> (ø)
modules/src/ics07_tendermint/error.rs 75.0% <ø> (+75.0%) ⬆️
modules/src/ics18_relayer/error.rs 0.0% <0.0%> (ø)
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe7366...ece606f. Read the comment docs.

@adizere adizere merged commit e3a8384 into master Oct 9, 2020
@adizere adizere deleted the romac/fix-master branch October 9, 2020 14:55
@adizere
Copy link
Member

adizere commented Oct 9, 2020

We'll make the Height type conversions smoother in a subsequent PR, tracked here: #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants