Custom proof specs in config #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu55a1n1
commented
Nov 17, 2021
hu55a1n1
force-pushed
the
hu55a1n1/1561-custom-proof-specs
branch
from
2ab53cf
to
3873c11
Compare
hu55a1n1
commented
Nov 19, 2021
| @@ -1,6 +1,7 @@ | |||
| use crate::prelude::*; | |||
| use ibc_proto::ics23::ProofSpec as ProtoProofSpec; | |||
| use ics23::ProofSpec; | |||
There was a problem hiding this comment.
Just FYI, with regard to #853 - this file (i.e. modules/src/core/ics23_commitment/specs.rs) is the only place where we use the ics23 crate. We only use it to get the definitions for the proof-specs for cosmos and to provide convert::From impls for our domain type (i.e. ProofSpecs). For all other cases, we use the ibc_proto::ics23 defs because we need to derive serde and other traits for these types.
hu55a1n1
commented
Nov 19, 2021
hu55a1n1
commented
Nov 19, 2021
romac
reviewed
Nov 24, 2021
romac
reviewed
Nov 24, 2021
mzabaluev
reviewed
Nov 24, 2021
romac
approved these changes
Nov 25, 2021
adizere
reviewed
Dec 1, 2021
| @@ -223,6 +223,60 @@ memo_prefix = '' | |||
| # ['transfer', 'channel-0'], | |||
| # ] | |||
|
|
|||
| # Specify custom ICS23 proof-specs for the chain (serialized as JSON). | |||
| # Default: [`ProofSpecs::cosmos()`](modules/src/core/ics23_commitment/specs.rs) | |||
| proof-specs = ''' | |||
There was a problem hiding this comment.
Is there a more operator-friendly manner to specify this? I tried to give an alternative suggestion in #1630 .
hu55a1n1
added a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Impl serde for ics23 proto types * Add proof specs to client state * Get proof specs from chain config * Fix test compilation * Define ProofSpecs domain type using ibc_proto::ics23 types * Minor refactoring * Add attrs for ics23 protos in proto-compiler * Fix clippy errors * Refactor Tendermint to use domain type * Parse config proofspecs as JSON serialized string * Add Default impl for ProofSpecs * Use serde(with) instead of newtype * Get rid of unwraps * Fix failing test * Document proof-specs opt in config * Minor refactoring to match style * Create .changelog entry * Serialilze ProofSpecs as a pretty formatted JSON string * Set serde dep version to '1' * Manually implement conversions b/w ProofSpec protos * Disallow empty proof-specs * Move custom serde serializer to its own module Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: cosmos/ibc-rs#67
Description
Proof specs are currently read as JSON serialized TOML strings from the config.
Serialize/Deserializeare derived on theibc_proto::ics23types.For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.