Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit events batch after a configurable delay #3327

Merged
merged 7 commits into from
May 18, 2023
Merged

Conversation

romac
Copy link
Member

@romac romac commented May 12, 2023

Closes: #3331

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac marked this pull request as ready for review May 16, 2023 10:09
Copy link
Contributor

@seanchen1991 seanchen1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @romac !

@ancazamfir ancazamfir merged commit ed07f57 into master May 18, 2023
30 checks passed
@ancazamfir ancazamfir deleted the perf/batch-delay branch May 18, 2023 16:17
pratikbin pushed a commit to pratikbin/hermes that referenced this pull request May 24, 2023
* Emit batch either on next block or after 1 second

* Instrument event monitor

* Emit all events received either on next block or after 1 second

* Formatting

* Make the batch delay configurable (default: 500ms)

* Add changelog entry

* Lower tracing level in stream utility

---------

Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up relaying by emitting event batches after a configurable delay
4 participants