-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit events batch after a configurable delay #3327
Conversation
* Instrument event monitor * Emit all events received either on next block or after 1 second * Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @romac !
* Emit batch either on next block or after 1 second * Instrument event monitor * Emit all events received either on next block or after 1 second * Formatting * Make the batch delay configurable (default: 500ms) * Add changelog entry * Lower tracing level in stream utility --------- Co-authored-by: Sean Chen <seanchen11235@gmail.com>
Closes: #3331
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.