Fix the flexible conn id for connection messages #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#334 +/- ##
=========================================
+ Coverage 13.6% 36.6% +22.9%
=========================================
Files 69 127 +58
Lines 3752 8200 +4448
Branches 1374 2842 +1468
=========================================
+ Hits 513 3007 +2494
- Misses 2618 5017 +2399
+ Partials 621 176 -445
Continue to review full report at Codecov.
|
romac
approved these changes
Oct 21, 2020
Allow None in Counterparty structure.
romac
requested changes
Oct 22, 2020
Co-authored-by: Romain Ruetschi <romain@informal.systems>
Co-authored-by: Romain Ruetschi <romain@informal.systems>
romac
requested changes
Oct 22, 2020
romac
approved these changes
Oct 22, 2020
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
* Fix the flexible conn id in Try and Ack for connection * Avoid cloning in MsgConnectionOpenAck::counterparty_connection_id * Avoid a (safe) use of unwrap * Add check for counterparty_connection_id new field in Try handler. Allow None in Counterparty structure. * fix fmt * Make the dest conn id optional in the tx raw cli * Update changelog * Update modules/src/ics03_connection/msgs/conn_open_try.rs Co-authored-by: Romain Ruetschi <romain@informal.systems> * Update modules/src/ics03_connection/msgs/conn_open_ack.rs Co-authored-by: Romain Ruetschi <romain@informal.systems> * fix conversions * simplify more * review comments Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #332
Description
While the message handlers are correct, the encoding for the new connection id fields in Try and Ack connection message domain types should be
Option<ConnectionId>Focused code review and more tests will be done as part https://github.com/informalsystems/ibc-rs/issues/306.
For contributor use:
docs/) and code commentsFiles changedin the Github PR explorer