Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing check for already received packets on ordered channels #54

Closed
5 tasks
hu55a1n1 opened this issue Feb 16, 2022 · 0 comments · Fixed by informalsystems/hermes#1838
Closed
5 tasks

Missing check for already received packets on ordered channels #54

hu55a1n1 opened this issue Feb 16, 2022 · 0 comments · Fixed by informalsystems/hermes#1838
Assignees
@hu55a1n1
Labels
A: bug Admin: something isn't working

Comments

@hu55a1n1
Copy link
Contributor

Crate

ibc

Summary of Bug

We must check if a packet has already been relayed on ordered channels and return a PacketAlreadyReceived error. We also need to treat this as a no-op at the dispatch level and emit the right events (note that events are missing in both un-/ordered cases).

Version

master

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 self-assigned this Feb 16, 2022
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Feb 16, 2022
@hu55a1n1 hu55a1n1 mentioned this issue Feb 17, 2022
Merged
6 tasks
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@ethanfrey
Merge pull request cosmos#54 from informalsystems/romac/tryinto-error
17c3466 
Use explicit conversion to `anyhow::Error` to fix compilation in `no_std` mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hu55a1n1 hu55a1n1

Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete ICS26 routing module implementation informalsystems/hermes
1 participant
@hu55a1n1