Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: WebSocket client cannot parse Tx events #1003

Closed
thomas-nguy opened this issue Oct 2, 2021 · 2 comments
Closed

rpc: WebSocket client cannot parse Tx events #1003

thomas-nguy opened this issue Oct 2, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@thomas-nguy
Copy link

This error occurs only with Ethermint message which add a log event there

https://github.com/tharsis/ethermint/blob/main/x/evm/keeper/msg_server.go#L58

The websocket is unable to receive the tx result. I am assuming it is related to deserialization.

I managed to narrowed down the issue to those line

https://github.com/informalsystems/tendermint-rs/blob/master/rpc/src/event.rs#L75
https://github.com/informalsystems/tendermint-rs/blob/master/tendermint/src/abci/tag.rs#L50

And if I remove

    #[serde(
        serialize_with = "base64string::serialize",
        deserialize_with = "base64string::deserialize_to_string"
    )]

from the tag's Values, then it fixes the issue (I can see the tx from websocket)

Any idea how this could be fixed in a clean way?

@thanethomson
Copy link
Member

How can we reproduce this to confirm?

One way of testing this out (with more verbose logging) is to use our RPC CLI.

@thomas-nguy
Copy link
Author

Hi @thanethomson

We decided to fix the issue on Ethermint side

evmos/ethermint#614

Closing the ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants