Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Export Client trait unconditionally #1235

Closed
artemii235 opened this issue Nov 17, 2022 · 0 comments · Fixed by #1305
Closed

rpc: Export Client trait unconditionally #1235

artemii235 opened this issue Nov 17, 2022 · 0 comments · Fixed by #1305
Labels
enhancement New feature or request

Comments

@artemii235
Copy link

Description

As of now, Client trait is defined and exported only if http-client or websocket-client features are enabled:
https://github.com/informalsystems/tendermint-rs/blob/main/rpc/src/lib.rs#L39

So, if crate users prefer to implement their own client, they have to enable features, which they don't need. Enabling these also leads to adding a bunch of unneeded subdeps.
In our project, we had to copy the entire trait definition to work this around:
https://github.com/KomodoPlatform/atomicDEX-API/pull/1546/files#diff-f0f8ba08e587c05523df40e172e6073ab961cdd4517eda6073b14f17d07e1d66R30

Definition of "done"

Define and export Client trait, not depending on http-client and websocket-client features.

@artemii235 artemii235 added the enhancement New feature or request label Nov 17, 2022
@romac romac changed the title [tendermint-rpc] Export HTTP Client trait unconditionally. [tendermint-rpc] Export HTTP Client trait unconditionally Apr 27, 2023
@romac romac changed the title [tendermint-rpc] Export HTTP Client trait unconditionally [tendermint-rpc] Export Client trait unconditionally Apr 27, 2023
@romac romac changed the title [tendermint-rpc] Export Client trait unconditionally rpc: Export Client trait unconditionally Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant