Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcast_tx_commit response data property can be null #216

Closed
sphw opened this issue Apr 15, 2020 · 2 comments · Fixed by #299
Closed

broadcast_tx_commit response data property can be null #216

sphw opened this issue Apr 15, 2020 · 2 comments · Fixed by #299
Assignees

Comments

@sphw
Copy link

sphw commented Apr 15, 2020

Some responses to broadcast_tx_commit will have a value of null for the data field in both check_tx and deliver_tx. Right now the fields aren't marked optional so it leads to an error being thrown by Serde. This could be solved in two ways. The data field could be marked as default and Serde would handle this, or the field could simply be an optional

@ebuchman ebuchman added this to the v0.33 Compatibility milestone Jun 3, 2020
@liamsi
Copy link
Member

liamsi commented Jun 3, 2020

I really, really think we should use the proto files to generate the abci types instead of manually curate them (see discussions in #29)

@liamsi
Copy link
Member

liamsi commented Jun 3, 2020

Oh, this actually about the rpc types. Here, we need better integration tests. It seems that these edge cases often aren't tested properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants