Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light client testing: remove implementation specific assertions about number of bisections #276

Closed
liamsi opened this issue May 18, 2020 · 0 comments · Fixed by #295
Closed

Light client testing: remove implementation specific assertions about number of bisections #276

liamsi opened this issue May 18, 2020 · 0 comments · Fixed by #295
Labels
light-client Issues/features which involve the light client
Milestone
v0.15.0

Comments

@liamsi
Copy link
Member

liamsi commented May 18, 2020

JSON tests: remove assertions for number of bisections as they are an implementation detail
see: #273 (comment)
@liamsi liamsi changed the title Light client testing Light client testing: remove implementation specific details May 18, 2020
@liamsi liamsi mentioned this issue May 18, 2020
Merged
5 tasks
@romac romac added the light-client Issues/features which involve the light client label May 25, 2020
@romac romac mentioned this issue May 25, 2020
Closed
19 tasks
@ebuchman ebuchman changed the title Light client testing: remove implementation specific details Light client testing: remove implementation specific assertions about number of bisections Jun 2, 2020
@ebuchman ebuchman added this to the Light Node milestone Jun 2, 2020
@liamsi liamsi mentioned this issue Jun 3, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
light-client Issues/features which involve the light client
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

light tests: remove assertions about number of bisections informalsystems/tendermint-rs
3 participants
@romac @ebuchman @liamsi