Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add voting power of the same validator multiple times in voting_power_in #335

Closed
milosevic opened this issue Jun 17, 2020 · 1 comment · Fixed by #306
Closed

Don't add voting power of the same validator multiple times in voting_power_in #335

milosevic opened this issue Jun 17, 2020 · 1 comment · Fixed by #306
Labels
light-client Issues/features which involve the light client

Comments

@milosevic
Copy link
Contributor

milosevic commented Jun 17, 2020 •
edited
Loading

There is a TODO already in the code:

tendermint-rs/light-client/src/operations/voting_power.rs

Line 38 in 184a1f9

// TODO: we still need to check that we didn't see a vote from this validator twice ...

@milosevic milosevic added the light-client Issues/features which involve the light client label Jun 17, 2020
@romac
Copy link
Member

romac commented Jun 18, 2020

Addressed in #306 (024a73d)

@romac romac mentioned this issue Jun 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
light-client Issues/features which involve the light client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix VotingPowerCalculator::voting_power_in informalsystems/tendermint-rs
2 participants
@romac @milosevic