Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DuplicateVoteEvidence PublicKey #502

Closed
greg-szabo opened this issue Aug 4, 2020 · 2 comments · Fixed by #589
Closed

Remove DuplicateVoteEvidence PublicKey #502

greg-szabo opened this issue Aug 4, 2020 · 2 comments · Fixed by #589
Assignees
@thanethomson
Labels
enhancement New feature or request serialization
Milestone
v0.17.0

Comments

@greg-szabo
Copy link
Member

I just noted that in the go versions there is no pubkey field (anymore?). We need to remove this for compatibility. Tracking here: #300

Originally posted by @liamsi in #242
@tac0turtle
Copy link
Contributor

Not sure the path that has been taken in the repo, but it may be best to fetch the proto files and use those to generate your evidence types.

@xla xla added enhancement New feature or request serialization labels Aug 4, 2020
@greg-szabo
Copy link
Member Author

Cool, thanks for the note. I'll visit this issue when I have the protos compiled into Rust.

@greg-szabo greg-szabo self-assigned this Sep 10, 2020
@ebuchman ebuchman mentioned this issue Sep 16, 2020
Closed
@ebuchman ebuchman assigned thanethomson and unassigned greg-szabo Sep 29, 2020
@thanethomson thanethomson mentioned this issue Sep 29, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanethomson thanethomson

Labels
enhancement New feature or request serialization
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging a pull request may close this issue.

Remove public key field from DuplicateVoteEvidence informalsystems/tendermint-rs
4 participants
@xla @thanethomson @greg-szabo @tac0turtle