Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper serialization for evidence::Params and Duration #741

Open
greg-szabo opened this issue Dec 14, 2020 · 0 comments
Open

Proper serialization for evidence::Params and Duration #741

greg-szabo opened this issue Dec 14, 2020 · 0 comments

Comments

@greg-szabo
Copy link
Member

evidence::Params is currently JSON serializes the domain struct. It could easily be converted to the tendermint_proto::types::EvidenceParams struct instead, since it's already its proto-type.

It contains a Duration which is also a mess: there's evidence::Duration which contains a std::time::Duration but all of them should fall back to the protobuf struct google::protobuf::Duration. This can be cleared up.

This is low priority, so we shouldn't do it for 0.17.0 but it would be nice to have afterwards.

@greg-szabo greg-szabo added this to the v0.18 milestone Dec 14, 2020
@thanethomson thanethomson removed this from the v0.19 milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants