Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prost 0.7 uses core types instead of std #871

Closed
greg-szabo opened this issue Apr 29, 2021 · 2 comments · Fixed by #920
Closed

prost 0.7 uses core types instead of std #871

greg-szabo opened this issue Apr 29, 2021 · 2 comments · Fixed by #920
Labels
enhancement New feature or request question Further information is requested

Comments

@greg-szabo
Copy link
Member

greg-szabo commented Apr 29, 2021

Prost 0.7 moved all internally used types (Vec, String, etc) generated from the core library, instead of std.

This is cool for our no-std approach but will it have any impact on downstream projects?

What's the definition of "done" for this issue?
Get an answer if we're ok going ahead with using core types in tendermint-proto.
We should rebuild the proto library if this is ok.

@greg-szabo greg-szabo added enhancement New feature or request question Further information is requested labels Apr 29, 2021
@tony-iqlusion
Copy link
Collaborator

std is just a facade for core/alloc anyway. It's not really an issue.

@thanethomson
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants